Desktop: Resolves #11575: Move "URI malformed" alert to the log

[wh201906]

Resolves #11575

The "URI malformed" alert is triggered here.

joplin/packages/lib/services/interop/InteropService_Importer_Md.ts

Line 113 in 2b43a9a

const link = decodeURI(encodedLink);

The "malformed" link is less likely to be a Resource URI, so we can leave it as it is. I add the catch statement to prevent the alert dialog and log it as a warning.

[wh201906]

We can also log it with logger.info() rather than logger.warn(), For the "malformed" link, the content won't be changed and it doesn't affect the APP so no need to worry about it.

[laurent22]

Thanks for the pr. Is there not a built-in logger in importers with this.logger? (Sorry don't have the code in front of me)

[wh201906]

There isn't such a logger in InteropService_Importer_Md and InteropService_Importer_Base, so I added it.

[laurent22]

No that's fine, no need to add it in this case. But we have a test file - any chance you could add a test based on it?

[wh201906]

No that's fine, no need to add it in this case.

@laurent22 So I don't even need to log the URI malformed alert in the log, right?

But we have a test file - any chance you could add a test based on it?

I've added it in commit d577ea9. The new test fails on the current dev branch (commit 2b43a9a), which is expected.
The new test is based on should not fail to import file that contains a link to a file that does not exist and should not import resources from file:// links