Skip to content

Commit

Permalink
Increased tolerance (#4064)
Browse files Browse the repository at this point in the history
* changed tolerance and updated references

* reverted changes
  • Loading branch information
JayHuLBL authored Nov 26, 2024
1 parent 0368613 commit 98a6e4b
Show file tree
Hide file tree
Showing 19 changed files with 174 additions and 138 deletions.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
simulateModel("Buildings.ThermalZones.EnergyPlus_24_2_0.Examples.SmallOffice.IdealHeatingCoolingSpring", startTime=7344000, stopTime=7776000, method="Radau", tolerance=1e-06, resultFile="IdealHeatingCoolingSpring");
simulateModel("Buildings.ThermalZones.EnergyPlus_24_2_0.Examples.SmallOffice.IdealHeatingCoolingSpring", startTime=7344000, stopTime=7776000, method="Radau", tolerance=1e-07, resultFile="IdealHeatingCoolingSpring");
createPlot(id=1, position={15, 15, 1496, 1040}, y={"flo.TAirCor", "flo.TAirSou", "flo.TAirNor", "flo.TAirEas", "flo.TAirWes"}, range={5.0, 10.0, 0.0, 40.0}, grid=true, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}, {0,0,0}}, timeUnit="d", displayUnits={"degC", "degC", "degC", "degC", "degC"});
createPlot(id=1, position={15, 15, 1496, 1040}, y={"hea[1].conPID.y", "hea[2].conPID.y", "hea[3].conPID.y", "hea[4].conPID.y", "hea[5].conPID.y"}, range={5.0, 10.0, -1.0, 2.0}, grid=true, subPlot=102, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}, {0,0,0}}, timeUnit="d");
createPlot(id=1, position={15, 15, 1496, 1040}, y={"flo.sou.heaPorAir.Q_flow", "flo.eas.heaPorAir.Q_flow", "flo.nor.heaPorAir.Q_flow", "flo.wes.heaPorAir.Q_flow", "flo.cor.heaPorAir.Q_flow"}, range={5.0, 10.0, -10000.0, 20000.0}, grid=true, subPlot=104, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}, {0,0,0}}, timeUnit="d", displayUnits={"W", "W", "W", "W", "W"});
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
simulateModel("Buildings.ThermalZones.EnergyPlus_24_2_0.Examples.SmallOffice.IdealHeatingCoolingSummer", startTime=16848000, stopTime=17280000, method="Radau", tolerance=1e-06, resultFile="IdealHeatingCoolingSummer");
simulateModel("Buildings.ThermalZones.EnergyPlus_24_2_0.Examples.SmallOffice.IdealHeatingCoolingSummer", startTime=16848000, stopTime=17280000, method="Radau", tolerance=1e-07, resultFile="IdealHeatingCoolingSummer");
createPlot(id=1, position={15, 15, 1496, 1040}, y={"flo.TAirCor", "flo.TAirSou", "flo.TAirNor", "flo.TAirEas", "flo.TAirWes"}, range={5.0, 10.0, 0.0, 40.0}, grid=true, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}, {0,0,0}}, timeUnit="d", displayUnits={"degC", "degC", "degC", "degC", "degC"});
createPlot(id=1, position={15, 15, 1496, 1040}, y={"hea[1].conPID.y", "hea[2].conPID.y", "hea[3].conPID.y", "hea[4].conPID.y", "hea[5].conPID.y"}, range={5.0, 10.0, -1.0, 2.0}, grid=true, subPlot=102, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}, {0,0,0}}, timeUnit="d");
createPlot(id=1, position={15, 15, 1496, 1040}, y={"flo.sou.heaPorAir.Q_flow", "flo.eas.heaPorAir.Q_flow", "flo.nor.heaPorAir.Q_flow", "flo.wes.heaPorAir.Q_flow", "flo.cor.heaPorAir.Q_flow"}, range={5.0, 10.0, -10000.0, 20000.0}, grid=true, subPlot=104, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}, {0,0,0}}, timeUnit="d", displayUnits={"W", "W", "W", "W", "W"});
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
simulateModel("Buildings.ThermalZones.EnergyPlus_24_2_0.Examples.SmallOffice.IdealHeatingCoolingWinter", startTime=432000, stopTime=864000, method="Radau", tolerance=1e-06, resultFile="IdealHeatingCoolingWinter");
simulateModel("Buildings.ThermalZones.EnergyPlus_24_2_0.Examples.SmallOffice.IdealHeatingCoolingWinter", startTime=432000, stopTime=864000, method="Radau", tolerance=1e-07, resultFile="IdealHeatingCoolingWinter");
createPlot(id=1, position={15, 15, 1496, 1040}, y={"flo.TAirCor", "flo.TAirSou", "flo.TAirNor", "flo.TAirEas", "flo.TAirWes"}, range={5.0, 10.0, 0.0, 40.0}, grid=true, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}, {0,0,0}}, timeUnit="d", displayUnits={"degC", "degC", "degC", "degC", "degC"});
createPlot(id=1, position={15, 15, 1496, 1040}, y={"hea[1].conPID.y", "hea[2].conPID.y", "hea[3].conPID.y", "hea[4].conPID.y", "hea[5].conPID.y"}, range={5.0, 10.0, -1.0, 2.0}, grid=true, subPlot=102, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}, {0,0,0}}, timeUnit="d");
createPlot(id=1, position={15, 15, 1496, 1040}, y={"flo.sou.heaPorAir.Q_flow", "flo.eas.heaPorAir.Q_flow", "flo.nor.heaPorAir.Q_flow", "flo.wes.heaPorAir.Q_flow", "flo.cor.heaPorAir.Q_flow"}, range={5.0, 10.0, -10000.0, 20000.0}, grid=true, subPlot=104, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}, {0,0,0}}, timeUnit="d", displayUnits={"W", "W", "W", "W", "W"});
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
simulateModel("Buildings.ThermalZones.EnergyPlus_9_6_0.Examples.SmallOffice.IdealHeatingCoolingSpring", startTime=7344000, stopTime=7776000, method="Radau", tolerance=1e-06, resultFile="IdealHeatingCoolingSpring");
simulateModel("Buildings.ThermalZones.EnergyPlus_9_6_0.Examples.SmallOffice.IdealHeatingCoolingSpring", startTime=7344000, stopTime=7776000, method="Radau", tolerance=1e-07, resultFile="IdealHeatingCoolingSpring");
createPlot(id=1, position={15, 15, 1496, 1040}, y={"flo.TAirCor", "flo.TAirSou", "flo.TAirNor", "flo.TAirEas", "flo.TAirWes"}, range={5.0, 10.0, 0.0, 40.0}, grid=true, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}, {0,0,0}}, timeUnit="d", displayUnits={"degC", "degC", "degC", "degC", "degC"});
createPlot(id=1, position={15, 15, 1496, 1040}, y={"hea[1].conPID.y", "hea[2].conPID.y", "hea[3].conPID.y", "hea[4].conPID.y", "hea[5].conPID.y"}, range={5.0, 10.0, -1.0, 2.0}, grid=true, subPlot=102, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}, {0,0,0}}, timeUnit="d");
createPlot(id=1, position={15, 15, 1496, 1040}, y={"flo.sou.heaPorAir.Q_flow", "flo.eas.heaPorAir.Q_flow", "flo.nor.heaPorAir.Q_flow", "flo.wes.heaPorAir.Q_flow", "flo.cor.heaPorAir.Q_flow"}, range={5.0, 10.0, -10000.0, 20000.0}, grid=true, subPlot=104, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}, {0,0,0}}, timeUnit="d", displayUnits={"W", "W", "W", "W", "W"});
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
simulateModel("Buildings.ThermalZones.EnergyPlus_9_6_0.Examples.SmallOffice.IdealHeatingCoolingSummer", startTime=16848000, stopTime=17280000, method="Radau", tolerance=1e-06, resultFile="IdealHeatingCoolingSummer");
simulateModel("Buildings.ThermalZones.EnergyPlus_9_6_0.Examples.SmallOffice.IdealHeatingCoolingSummer", startTime=16848000, stopTime=17280000, method="Radau", tolerance=1e-07, resultFile="IdealHeatingCoolingSummer");
createPlot(id=1, position={15, 15, 1496, 1040}, y={"flo.TAirCor", "flo.TAirSou", "flo.TAirNor", "flo.TAirEas", "flo.TAirWes"}, range={5.0, 10.0, 0.0, 40.0}, grid=true, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}, {0,0,0}}, timeUnit="d", displayUnits={"degC", "degC", "degC", "degC", "degC"});
createPlot(id=1, position={15, 15, 1496, 1040}, y={"hea[1].conPID.y", "hea[2].conPID.y", "hea[3].conPID.y", "hea[4].conPID.y", "hea[5].conPID.y"}, range={5.0, 10.0, -1.0, 2.0}, grid=true, subPlot=102, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}, {0,0,0}}, timeUnit="d");
createPlot(id=1, position={15, 15, 1496, 1040}, y={"flo.sou.heaPorAir.Q_flow", "flo.eas.heaPorAir.Q_flow", "flo.nor.heaPorAir.Q_flow", "flo.wes.heaPorAir.Q_flow", "flo.cor.heaPorAir.Q_flow"}, range={5.0, 10.0, -10000.0, 20000.0}, grid=true, subPlot=104, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}, {0,0,0}}, timeUnit="d", displayUnits={"W", "W", "W", "W", "W"});
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
simulateModel("Buildings.ThermalZones.EnergyPlus_9_6_0.Examples.SmallOffice.IdealHeatingCoolingWinter", startTime=432000, stopTime=864000, method="Radau", tolerance=1e-06, resultFile="IdealHeatingCoolingWinter");
simulateModel("Buildings.ThermalZones.EnergyPlus_9_6_0.Examples.SmallOffice.IdealHeatingCoolingWinter", startTime=432000, stopTime=864000, method="Radau", tolerance=1e-07, resultFile="IdealHeatingCoolingWinter");
createPlot(id=1, position={15, 15, 1496, 1040}, y={"flo.TAirCor", "flo.TAirSou", "flo.TAirNor", "flo.TAirEas", "flo.TAirWes"}, range={5.0, 10.0, 0.0, 40.0}, grid=true, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}, {0,0,0}}, timeUnit="d", displayUnits={"degC", "degC", "degC", "degC", "degC"});
createPlot(id=1, position={15, 15, 1496, 1040}, y={"hea[1].conPID.y", "hea[2].conPID.y", "hea[3].conPID.y", "hea[4].conPID.y", "hea[5].conPID.y"}, range={5.0, 10.0, -1.0, 2.0}, grid=true, subPlot=102, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}, {0,0,0}}, timeUnit="d");
createPlot(id=1, position={15, 15, 1496, 1040}, y={"flo.sou.heaPorAir.Q_flow", "flo.eas.heaPorAir.Q_flow", "flo.nor.heaPorAir.Q_flow", "flo.wes.heaPorAir.Q_flow", "flo.cor.heaPorAir.Q_flow"}, range={5.0, 10.0, -10000.0, 20000.0}, grid=true, subPlot=104, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}, {0,0,0}}, timeUnit="d", displayUnits={"W", "W", "W", "W", "W"});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ model IdealHeatingCoolingSpring
experiment(
StartTime=7344000,
StopTime=7776000,
Tolerance=1e-06),
Tolerance=1e-07),
Icon(
coordinateSystem(
extent={{-100,-100},{100,100}},
Expand All @@ -25,6 +25,12 @@ but configured for simulation of a few days in summer.
revisions="<html>
<ul>
<li>
November 25, 2024, by Jianjun Hu:<br/>
Changed tolerance to 1e-07.
This is for
<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/4063\">issue #4063</a>.
</li>
<li>
March 5, 2021, by Michael Wetter:<br/>
First implementation.
</li>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ model IdealHeatingCoolingSummer
experiment(
StartTime=16848000,
StopTime=17280000,
Tolerance=1e-06),
Tolerance=1e-07),
Icon(
coordinateSystem(
extent={{-100,-100},{100,100}},
Expand All @@ -25,6 +25,12 @@ but configured for simulation of a few days in summer.
revisions="<html>
<ul>
<li>
November 25, 2024, by Jianjun Hu:<br/>
Changed tolerance to 1e-07.
This is for
<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/4063\">issue #4063</a>.
</li>
<li>
March 5, 2021, by Michael Wetter:<br/>
First implementation.
</li>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,14 @@ equation
connect(QCoo_flow.y,ECoo.u)
annotation (Line(points={{-8,160},{-2,160}},color={0,0,127}));
connect(QCoo_flow.u[1:5],coo.Q_flow)
annotation (Line(points={{-32,158.4},{-46,158.4},{-46,146},{-58,146}},color={0,0,127}));
annotation (Line(points={{-32,160.8},{-46,160.8},{-46,146},{-58,146}},color={0,0,127}));
annotation (
__Dymola_Commands(
file="modelica://Buildings/Resources/Scripts/Dymola/ThermalZones/EnergyPlus_24_2_0/Examples/SmallOffice/IdealHeatingCoolingWinter.mos" "Simulate and plot"),
experiment(
StartTime=432000,
StopTime=864000,
Tolerance=1e-06),
Tolerance=1e-07),
Documentation(
info="<html>
<p>
Expand All @@ -91,6 +91,12 @@ but an ideal heating/cooling device that exactly meets the load.
revisions="<html>
<ul>
<li>
November 25, 2024, by Jianjun Hu:<br/>
Changed tolerance to 1e-07.
This is for
<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/4063\">issue #4063</a>.
</li>
<li>
March 4, 2021, by Michael Wetter:<br/>
First implementation.<br/>
This is for
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ model IdealHeatingCoolingSpring
experiment(
StartTime=7344000,
StopTime=7776000,
Tolerance=1e-06),
Tolerance=1e-07),
Icon(
coordinateSystem(
extent={{-100,-100},{100,100}},
Expand All @@ -25,6 +25,12 @@ but configured for simulation of a few days in summer.
revisions="<html>
<ul>
<li>
November 25, 2024, by Jianjun Hu:<br/>
Changed tolerance to 1e-07.
This is for
<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/4063\">issue #4063</a>.
</li>
<li>
March 5, 2021, by Michael Wetter:<br/>
First implementation.
</li>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ model IdealHeatingCoolingSummer
experiment(
StartTime=16848000,
StopTime=17280000,
Tolerance=1e-06),
Tolerance=1e-07),
Icon(
coordinateSystem(
extent={{-100,-100},{100,100}},
Expand All @@ -25,6 +25,12 @@ but configured for simulation of a few days in summer.
revisions="<html>
<ul>
<li>
November 25, 2024, by Jianjun Hu:<br/>
Changed tolerance to 1e-07.
This is for
<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/4063\">issue #4063</a>.
</li>
<li>
March 5, 2021, by Michael Wetter:<br/>
First implementation.
</li>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,14 @@ equation
connect(QCoo_flow.y,ECoo.u)
annotation (Line(points={{-8,160},{-2,160}},color={0,0,127}));
connect(QCoo_flow.u[1:5],coo.Q_flow)
annotation (Line(points={{-32,158.4},{-46,158.4},{-46,146},{-58,146}},color={0,0,127}));
annotation (Line(points={{-32,160.8},{-46,160.8},{-46,146},{-58,146}},color={0,0,127}));
annotation (
__Dymola_Commands(
file="modelica://Buildings/Resources/Scripts/Dymola/ThermalZones/EnergyPlus_9_6_0/Examples/SmallOffice/IdealHeatingCoolingWinter.mos" "Simulate and plot"),
experiment(
StartTime=432000,
StopTime=864000,
Tolerance=1e-06),
Tolerance=1e-07),
Documentation(
info="<html>
<p>
Expand All @@ -91,6 +91,12 @@ but an ideal heating/cooling device that exactly meets the load.
revisions="<html>
<ul>
<li>
November 25, 2024, by Jianjun Hu:<br/>
Changed tolerance to 1e-07.
This is for
<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/4063\">issue #4063</a>.
</li>
<li>
March 4, 2021, by Michael Wetter:<br/>
First implementation.<br/>
This is for
Expand Down

0 comments on commit 98a6e4b

Please sign in to comment.