Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parameter evaluation for applicable parameters after Modelon fix #2086

Closed
milicag opened this issue Aug 18, 2020 · 3 comments
Closed
Assignees

Comments

@milicag
Copy link
Contributor

milicag commented Aug 18, 2020

Optimica has a bug that causes test to fail for vector parameters.

To temporarily deal with the issue we replaced parameter definitions such as:

  parameter Real LIFT_min[nChi](
    final unit=fill("K",nChi),
    final quantity=fill("TemperatureDifference",nChi),
    displayUnit=fill("degC", nChi))={12, 12}
      "Minimum LIFT of each chiller";

With the CDL compliant version:

  parameter Real LIFT_min[nChi](
    final unit=fill("K",nChi),
    final quantity=fill("TemperatureDifference",nChi),
    displayUnit=fill("degC", nChi))={12, 12}
      "Minimum LIFT of each chiller"
    annotation (Evaluate=true);

As Evaluate=true imposes undesired limitations for the translator, this issue is to remove annotation (Evaluate=true); for all applicable parameter instances after Modelon fixes the error.

@milicag
Copy link
Contributor Author

milicag commented Aug 18, 2020

@JayHuLBL Thanks for clarifications.

@JayHuLBL
Copy link
Contributor

@milicag
With new OCT version OCT-r17595_JM-r14295, model PrimarySystem.ChillerPlant.Tower.Validation.Controller in branch issue1378_staging_primarySequences runs well after removing Evaluate=true from the annotation of the parameter LIFT_min, TConWatSup_nominal, TConWatRet_nominal, TChiWatSupMin of model PrimarySystem.ChillerPlant.Tower.Controller.

In OBC package, we could remove all the Evaluate=true annotation now.

@milicag milicag self-assigned this Oct 29, 2020
milicag added a commit that referenced this issue Dec 8, 2020
@milicag
Copy link
Contributor Author

milicag commented May 10, 2021

This is addressed on branch issue2293_chiller_plant_seq that is in a PR.

@milicag milicag closed this as completed May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants