Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue3711 desiccant dehumidifier #3748

Open
wants to merge 16 commits into
base: issue3711_desDehumidifier
Choose a base branch
from
Open

Issue3711 desiccant dehumidifier #3748

wants to merge 16 commits into from

Conversation

SenHuang19
Copy link

No description provided.

@SenHuang19 SenHuang19 changed the title Issue3711 des dehumidifier Issue3711 desiccant dehumidifier Mar 28, 2024
@SenHuang19
Copy link
Author

@JayHuLBL Could you please take a look at this PR?

@SenHuang19
Copy link
Author

@JayHuLBL it is ready for your review.

@JayHuLBL
Copy link
Contributor

@SenHuang19 All the new validation models are failed to run by Optimica.

(py395) jianjunhu@ubuntu:~/GitFolder/SenHuang19/modelica-buildings/Buildings$ ../bin/runUnitTests.py -s Buildings.Fluid.Dehumidifiers -t optimica
Regression tests are only run for the following package:
  Buildings.Fluid.Dehumidifiers
Number of models   : 2407
          blocks   : 581
          functions: 210
Using 3 of 4 processors to run unit tests for optimica.
Generated 3 regression tests.

*** Error: Translation of Buildings.Fluid.Dehumidifiers.Desiccant.BaseClasses.Validation.Performance failed: 'ModelicaClassNotFoundError: Class Buildings.Fluid.Dehumidifiers.Desiccant.BaseClasses.Validation.Performance not found'. Directory is '/tmp/tmp-Buildings-0-9nu9tg5d'.
*** Error: Translation of Buildings.Fluid.Dehumidifiers.Desiccant.Examples.ElectricCoilBypassDampers failed: 'ModelicaClassNotFoundError: Class Buildings.Fluid.Dehumidifiers.Desiccant.Examples.ElectricCoilBypassDampers not found'. Directory is '/tmp/tmp-Buildings-1-lxo3ycuo'.
*** Error: Translation of Buildings.Fluid.Dehumidifiers.Desiccant.Examples.ElectricCoilSpeedControlled failed: 'ModelicaClassNotFoundError: Class Buildings.Fluid.Dehumidifiers.Desiccant.Examples.ElectricCoilSpeedControlled not found'. Directory is '/tmp/tmp-Buildings-2-35_yfhan'.

Number of models that failed translation                     : 3
Comparison files output by funnel are stored in the directory 'funnel_comp' of size 0.0 MB.
Run 'python -c "import buildingspy.development.regressiontest as t; t.Tester(tool=\"optimica\").report()"'
to access a summary of the comparison results.

Script that runs unit tests had 0 warnings and 3 errors.

See 'simulator-optimica.log' for details.
Execution time = 6.207 s
Server will run for 600 (s) or until KeyboardInterrupt.
^Z
[3]+  Stopped                 ../bin/runUnitTests.py -s Buildings.Fluid.Dehumidifiers -t optimica

@SenHuang19
Copy link
Author

@SenHuang19 All the new validation models are failed to run by Optimica.

(py395) jianjunhu@ubuntu:~/GitFolder/SenHuang19/modelica-buildings/Buildings$ ../bin/runUnitTests.py -s Buildings.Fluid.Dehumidifiers -t optimica
Regression tests are only run for the following package:
  Buildings.Fluid.Dehumidifiers
Number of models   : 2407
          blocks   : 581
          functions: 210
Using 3 of 4 processors to run unit tests for optimica.
Generated 3 regression tests.

*** Error: Translation of Buildings.Fluid.Dehumidifiers.Desiccant.BaseClasses.Validation.Performance failed: 'ModelicaClassNotFoundError: Class Buildings.Fluid.Dehumidifiers.Desiccant.BaseClasses.Validation.Performance not found'. Directory is '/tmp/tmp-Buildings-0-9nu9tg5d'.
*** Error: Translation of Buildings.Fluid.Dehumidifiers.Desiccant.Examples.ElectricCoilBypassDampers failed: 'ModelicaClassNotFoundError: Class Buildings.Fluid.Dehumidifiers.Desiccant.Examples.ElectricCoilBypassDampers not found'. Directory is '/tmp/tmp-Buildings-1-lxo3ycuo'.
*** Error: Translation of Buildings.Fluid.Dehumidifiers.Desiccant.Examples.ElectricCoilSpeedControlled failed: 'ModelicaClassNotFoundError: Class Buildings.Fluid.Dehumidifiers.Desiccant.Examples.ElectricCoilSpeedControlled not found'. Directory is '/tmp/tmp-Buildings-2-35_yfhan'.

Number of models that failed translation                     : 3
Comparison files output by funnel are stored in the directory 'funnel_comp' of size 0.0 MB.
Run 'python -c "import buildingspy.development.regressiontest as t; t.Tester(tool=\"optimica\").report()"'
to access a summary of the comparison results.

Script that runs unit tests had 0 warnings and 3 errors.

See 'simulator-optimica.log' for details.
Execution time = 6.207 s
Server will run for 600 (s) or until KeyboardInterrupt.
^Z
[3]+  Stopped                 ../bin/runUnitTests.py -s Buildings.Fluid.Dehumidifiers -t optimica

@JayHuLBL thanks for letting me know this. I only tested the model in Dymola and it seems to work at my end. I don't have an optimica license. Can you please let me know if Modelon still offers development licenses to the Spawn project team? If so, I will request one.

@JayHuLBL
Copy link
Contributor

@SenHuang19 Just double checked. The error is due to the OS environment setup. After correcting the setup, it can run with Optimica.

JayHuLBL
JayHuLBL reviewed Apr 12, 2024
View reviewed changes
Buildings/Fluid/Dehumidifiers/Desiccant/BaseClasses/PartialDesiccant.mo Outdated
"Prescribed heat flow"
annotation (Placement(transformation(extent={{-62,50},{-82,30}})));
Modelica.Blocks.Sources.RealExpression mPro_flow(
final y(final unit="kg/s")= outCon.port_a.m_flow)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more space before final. In general, make sure the format looks consistent.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the inconsistent format.

JayHuLBL
JayHuLBL reviewed Apr 12, 2024
View reviewed changes
Buildings/Fluid/Dehumidifiers/Desiccant/BaseClasses/Performance.mo Outdated
within Buildings.Fluid.Dehumidifiers.Desiccant.BaseClasses;
model Performance
"Model calculates the outlet condition of the process air through a desiccant dehumidifier"
extends Modelica.Blocks.Icons.Block;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete one empty space before extends. Format

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the extra space.

JayHuLBL
JayHuLBL reviewed Apr 12, 2024
View reviewed changes
Buildings/Fluid/Dehumidifiers/Desiccant/BaseClasses/Performance.mo
final parameter Real uSpe_min = 0.3
"Minimum allowable wheel speed ratio";
Modelica.Blocks.Interfaces.BooleanInput onDeh
"Set to true to enable the dehumidification process" annotation (Placement(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the annotation() to new line.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

JayHuLBL
JayHuLBL reviewed Apr 12, 2024
View reviewed changes
Buildings/Fluid/Dehumidifiers/Desiccant/BaseClasses/Performance.mo Outdated
iconTransformation(extent={{-120,-92},{-100,-72}})));
Modelica.Blocks.Interfaces.RealInput mPro_flow(
final unit="kg/s") "Mass flow rate of the process air"
annotation (Placement(transformation(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct the format.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected the format.

JayHuLBL
JayHuLBL reviewed Apr 12, 2024
View reviewed changes
Buildings/Fluid/Dehumidifiers/Desiccant/BaseClasses/Performance.mo Outdated
"Coefficients for calculating the latent heat exchange effectiveness";
final parameter Real uSpe_min = 0.3
"Minimum allowable wheel speed ratio";
Modelica.Blocks.Interfaces.BooleanInput onDeh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the onDeh to uRot

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed.

JayHuLBL
JayHuLBL reviewed Apr 12, 2024
View reviewed changes
Buildings/Fluid/Dehumidifiers/Desiccant/BaseClasses/Performance.mo Outdated
"Latent heat exchange effectiveness";

equation
if onDeh then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this section, please ensure the indent in right way.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the extra spaces.

JayHuLBL
JayHuLBL reviewed Apr 12, 2024
View reviewed changes
Buildings/Fluid/Dehumidifiers/Desiccant/BaseClasses/Performance.mo Outdated
<li>
If the dehumidification signal <code>onDeh=true</code>,
<ul>
<li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure no empty space in front of each sentence.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the extra spaces.

JayHuLBL
JayHuLBL reviewed Apr 12, 2024
View reviewed changes
Buildings/Fluid/Dehumidifiers/Desiccant/BaseClasses/Performance.mo Outdated

</html>", revisions="<html>
<ul>
<li>April 10, 2024, by Sen Huang:<br/>Added wheel speed ratio as an input. </li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not need to add the second revision record, as it is still the first implementation.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the revision record.

JayHuLBL
JayHuLBL reviewed Apr 12, 2024
View reviewed changes
Buildings/Fluid/Dehumidifiers/Desiccant/BaseClasses/performanceCurve.mo
<h4>References</h4>
<ul>
<li>
<a href=\"https://energyplus.net/assets/nrel_custom/pdfs/pdfs_v22.1.0/EngineeringReference.pdf\">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the reference format as
U.S. Department of Energy, <i> &quot;EnergyPlus Version 22.1.0 Documentation: Engineering Reference&quot;. </i>

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced the reference text as suggested

JayHuLBL
JayHuLBL reviewed Apr 12, 2024
View reviewed changes
Buildings/Fluid/Dehumidifiers/Desiccant/Data/Default.mo Outdated
@@ -0,0 +1,51 @@
within Buildings.Fluid.Dehumidifiers.Desiccant.Data;
record Default =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may rename it as EnergyPlus. See Buildings.Fluid.HeatPumps.Data.EquationFitReversible

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed the model as suggested.

JayHuLBL
JayHuLBL reviewed Apr 12, 2024
View reviewed changes
Buildings/Fluid/Dehumidifiers/Desiccant/ElectricCoilSpeedControlled.mo Outdated
annotation (Dialog(group="Efficiency"));
parameter Real c[:] = {1}
"Coefficients for power consumption curve for the rotor,
P/P_nominal = sum a_i uSpe^(i-1). The sum(a) of the elements must be equal to 1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't include any equation in comment. Also don't include the variable names in the comment.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the equation and variable name.

JayHuLBL
JayHuLBL requested changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@JayHuLBL JayHuLBL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SenHuang19 See inline comments.
Also, is it possible to change the figures (like Buildings/Resources/Images/Fluid/Dehumidifiers/Desiccant/BaseClasses/system_schematic_VFD.png)to different format? Usually, each figure in our library has the .svg format and .png format, see for example in Buildings/Resources/Images/Fluid/CHPs.

@JayHuLBL
Copy link
Contributor

@SenHuang19 Let me when it is ready for another review.

@SenHuang19
Copy link
Author

SenHuang19 commented Apr 18, 2024 •
edited
Loading

@SenHuang19 Let me when it is ready for another review.

@JayHuLBL Thanks for checking with me. It is ready for your review.

@SenHuang19
Copy link
Author

  • Move the package to Buildings.Fluid.HeatExchangers.Dehumidifiers

@SenHuang19
Copy link
Author

Will update this PR once #3554 is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JayHuLBL JayHuLBL JayHuLBL requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SenHuang19 @JayHuLBL