Issue3538 thermal wheel #3909

SenHuang19 · 2024-06-22T20:53:26Z

Update the revision history for Thermal wheels #3554 (comment)
Specify the definition of 75% part load for Thermal wheels #3554 (comment)
Replace the volumetric flow rates with mass flow rates for Thermal wheels #3554 (comment)
Replace the RealExpression blocks with mass flow sensors
Only one medium object is needed
Wrong pressure values for the damper for Thermal wheels #3554 (comment)
Modify the layout of the connection lines in the icons so that they don't lay on top of other lines, and are aligned with the grid
Add Buildings.Fluid.HeatExchangers.BaseClasses.VariableSpeedThermalWheels for accounting for the impacts of wheel speed ratios on the wheel performance
Add realistic examples Buildings.Fluid.HeatExchangers.ThermalWheels.Sensible.Examples.SpaceCooling
and Buildings.Fluid.HeatExchangers.ThermalWheels.Latent.Examples.SpaceCooling

JayHuLBL · 2024-08-12T20:48:10Z

...riableSpeedThermalWheels/BaseClasses/Characteristics/heatExchangerEffectivenessParameters.mo

+Data record that describes wheel speed ratio <code>uSpe</code> versus
+heat exchange effectiveness corrections <code>epsCor</code>, i.e., the ratio of the heat exchange effectiveness 
+to that when the <code>uSpe</code> is <i>1</i>.
+The wheel speed ratio <code>uSpe</code> must be increasing, 


The elements of the vector <code>uSpe</code> should be in ascending order,

Update the model doc as suggested.

JayHuLBL · 2024-08-12T20:53:40Z

...eClasses/VariableSpeedThermalWheels/BaseClasses/Characteristics/motorEfficiencyParameters.mo

@@ -0,0 +1,26 @@
+within Buildings.Fluid.HeatExchangers.BaseClasses.VariableSpeedThermalWheels.BaseClasses.Characteristics;
+record motorEfficiencyParameters
+  "Record for motor efficiency parameters vs. wheel speed ratio"


Parameters for defining motor efficiency at different wheel speed ratio

Update the model doc as suggested.

JayHuLBL · 2024-08-12T20:55:34Z

...riableSpeedThermalWheels/BaseClasses/Characteristics/heatExchangerEffectivenessParameters.mo

@@ -0,0 +1,27 @@
+within Buildings.Fluid.HeatExchangers.BaseClasses.VariableSpeedThermalWheels.BaseClasses.Characteristics;
+record heatExchangerEffectivenessParameters
+  "Record for heat exchanger effectiveness correction vs. wheel speed ratio"


Parameters for defining heat exchanger effectiveness at different wheel speed ratio

Update the model doc as suggested.

JayHuLBL · 2024-08-12T20:56:18Z

...riableSpeedThermalWheels/BaseClasses/Characteristics/heatExchangerEffectivenessParameters.mo

+  parameter Real uSpe[:](each min=0)
+    "Wheel speed ratio";
+  parameter Real epsCor[:](each max=1)
+    "Correction of the heat exchange effectiveness under a given speed ratio";


Correction of the heat exchange effectiveness at a given speed ratio

Update the model doc as suggested.

JayHuLBL · 2024-08-12T21:10:02Z

...ings/Fluid/HeatExchangers/BaseClasses/VariableSpeedThermalWheels/BaseClasses/Data/Generic.mo

+</p>
+<ul>
+<li>
+wheel speed ratio versus motor percent full-load


Better put the wheel speed ratio at the end, so it will be like:
motor efficiency versus wheel speed ratio,
sensible heat exchange effectiveness corrections versus wheel speed ratio,
...

Update the model doc as suggested.

JayHuLBL · 2024-08-12T22:03:00Z

Buildings/Fluid/HeatExchangers/BaseClasses/VariableSpeedThermalWheels/Sensible.mo

+<p>
+where <code>P_nominal</code> is the nominal wheel power consumption,
+<code>uSpe</code> is the wheel speed ratio, 
+and the <code>eta</code> is the motor percent full-load efficiency, i.e.,


need a clear explanation of the eta, what is it? is it eff(uSpe=x) / eff(uSpe=1), where the eff(uSpe=x)is the motor efficiency when the speed ratio isx`?

Added the detailed explanation as suggested.

JayHuLBL

@SenHuang19 Please see inline comments

SenHuang19 · 2024-09-03T19:39:34Z

@SenHuang19 Please see inline comments

@JayHuLBL I believe I have addressed all your comments. Could you please resume your review?

JayHuLBL · 2024-11-13T00:00:20Z

Buildings/Fluid/HeatExchangers/BaseClasses/VariableSpeedThermalWheels/Latent.mo

+on the cubic hermite spline interpolation of the latent heat exchange 
+effectiveness dataset (see 
+<a href=\"modelica://Buildings.Fluid.HeatExchangers.BaseClasses.VariableSpeedThermalWheels.BaseClasses.Characteristics.heatExchangerEffectivenessParameters\">
+Buildings.Fluid.HeatExchangers.BaseClasses.BaseClasses.VariableSpeedThermalWheels.Characteristics.heatExchangerEffectivenessParameters</a>).


Bildings.Fluid.HeatExchangers.BaseClasses.VariableSpeedThermalWheels.BaseClasses.

JayHuLBL · 2024-11-13T00:03:34Z

Buildings/Fluid/HeatExchangers/BaseClasses/VariableSpeedThermalWheels/Sensible.mo

+The <code>eta</code> is obtained based on the cubic hermite spline interpolation of
+the motor percent full-load efficiency dataset (see 
+<a href=\"modelica://Buildings.Fluid.HeatExchangers.BaseClasses.VariableSpeedThermalWheels.BaseClasses.Characteristics.motorEfficiencyParameters\">
+Buildings.Fluid.HeatExchangers.BaseClasses.BaseClasses.VariableSpeedThermalWheels.Characteristics.motorEfficiencyParameters</a>).


correct the model path

JayHuLBL · 2024-11-13T00:03:46Z

Buildings/Fluid/HeatExchangers/BaseClasses/VariableSpeedThermalWheels/Sensible.mo

+The sensible heat exchanger effectiveness correction is calculated based 
+on the cubic hermite spline interpolation of the sensible heat exchanger effectiveness 
+dataset (see <a href=\"modelica://Buildings.Fluid.HeatExchangers.BaseClasses.VariableSpeedThermalWheels.BaseClasses.Characteristics.heatExchangerEffectivenessParameters\">
+Buildings.Fluid.HeatExchangers.BaseClasses.BaseClasses.VariableSpeedThermalWheels.Characteristics.heatExchangerEffectivenessParameters</a>).


correct the model path

JayHuLBL

Run unit test gives following error. Please check if the result difference is expected.

ianjunhu@ubuntu:~/GitFolder/SenHuang19/modelica-buildings/Buildings$ ../bin/runUnitTests.py -s Buildings.Fluid.HeatExchangers.ThermalWheels
Regression tests are only run for the following package:
  Buildings.Fluid.HeatExchangers.ThermalWheels
Number of models   : 2471
          blocks   : 613
          functions: 210
Using 4 of 4 processors to run unit tests for dymola.
Generated 10 regression tests.

*** Error: Buildings_Fluid_HeatExchangers_ThermalWheels_Latent_Examples_SpaceCooling.txt: Errors during result verification.
           Absolute error = 3.807e+00 at t = 15615072.0 for cooCoi.sta_a2.T
             For Buildings_Fluid_HeatExchangers_ThermalWheels_Latent_Examples_SpaceCooling.txt,
             update reference files with new trajectories?
             Enter: y(yes), n(no), Y(yes for all), N(no for all): N
*** Error: Buildings_Fluid_HeatExchangers_ThermalWheels_Sensible_Examples_SpaceCooling.txt: Errors during result verification.
           Absolute error = 5.767e+00 at t = 15569280.0 for cooCoi.sta_a2.T
Comparison files output by funnel are stored in the directory 'funnel_comp' of size 0.6 MB.
Run 'python -c "import buildingspy.development.regressiontest as t; t.Tester(tool=\"dymola\").report()"'
to access a summary of the comparison results.

@SenHuang19 Please address the comments. Otherwise, it is ready to merge.

SenHuang19 added 21 commits May 6, 2024 11:24

model implementation improve

de43d6c

improve the implementation and examples

40a863c

model improve and clean

e265a62

update the scripts

c803b24

update the reference data

a11281b

model doc update and example improves

8a14a33

update the power calculation

cfdf906

update the model directory

01c29ac

update the thermal wheels

0c728c6

update scripts

4c757ae

update the reference dataset

d60cb27

improve the model doc

206d94f

model doc improve and typo fix

c63596a

reference data update

030d1cc

model doc update

49341ae

model doc improve

3a28f6d

format update

84f9d01

format update

822e498

minor changes to model implementation

5711f57

reference data update

81b0f28

minor change

1af8bcb

mwetter assigned JayHuLBL Jun 24, 2024

model doc update

3b4309d

JayHuLBL reviewed Aug 12, 2024

View reviewed changes

SenHuang19 added 3 commits August 14, 2024 16:41

improve the model doc

df18e6b

model doc improve

37f3c7d

model doc update

ee21c9f

SenHuang19 mentioned this pull request Sep 18, 2024

Thermal wheels #3554

Open

Huang and others added 2 commits September 26, 2024 16:07

change the performance dataset into parameters

4da862d

minor doc format update

0b7f334

JayHuLBL reviewed Nov 13, 2024

View reviewed changes

JayHuLBL requested changes Nov 19, 2024

View reviewed changes

Huang added 2 commits November 22, 2024 12:14

fix typos

d27b421

update reference

1e96958

JayHuLBL merged commit ba6c61e into lbl-srg:issue3538_Air2Air_recovery Nov 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue3538 thermal wheel #3909

Issue3538 thermal wheel #3909

SenHuang19 commented Jun 22, 2024 •

edited

Loading

JayHuLBL Aug 12, 2024

SenHuang19 Sep 2, 2024

JayHuLBL Aug 12, 2024

SenHuang19 Sep 2, 2024

JayHuLBL Aug 12, 2024

SenHuang19 Sep 2, 2024

JayHuLBL Aug 12, 2024

SenHuang19 Sep 2, 2024

JayHuLBL Aug 12, 2024

SenHuang19 Sep 2, 2024

JayHuLBL Aug 12, 2024

SenHuang19 Sep 2, 2024

JayHuLBL left a comment

SenHuang19 commented Sep 3, 2024

JayHuLBL Nov 13, 2024

JayHuLBL Nov 13, 2024

JayHuLBL Nov 13, 2024

JayHuLBL left a comment •

edited

Loading

Issue3538 thermal wheel #3909

Issue3538 thermal wheel #3909

Conversation

SenHuang19 commented Jun 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JayHuLBL left a comment

Choose a reason for hiding this comment

SenHuang19 commented Sep 3, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JayHuLBL left a comment • edited Loading

Choose a reason for hiding this comment

SenHuang19 commented Jun 22, 2024 •

edited

Loading

JayHuLBL left a comment •

edited

Loading