Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add structure rxn rep #19

Merged
merged 7 commits into from
Feb 20, 2024
Merged

Add structure rxn rep #19

merged 7 commits into from
Feb 20, 2024

Conversation

briling
Copy link
Contributor

@briling briling commented Feb 15, 2024

Add:

  • SLATM
  • SLATM_d for rxns
  • B2R2

@briling briling requested a review from puckvg February 15, 2024 17:11
Copy link
Contributor

@puckvg puckvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In b2r2.py:

  • why in line 105, 2.0*np.concatenate(twobodyrep)? i.e why multiply by 2?

Otherwise seems good!

@puckvg puckvg merged commit 8fff4fc into master Feb 20, 2024
2 of 3 checks passed
@puckvg puckvg deleted the add-structure-rxn-rep branch February 20, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants