Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add orca gbw #52

Merged
merged 8 commits into from
Sep 26, 2024
Merged

Add orca gbw #52

merged 8 commits into from
Sep 26, 2024

Conversation

briling
Copy link
Contributor

@briling briling commented May 21, 2024

  • check .gbw reader @ 4.0.0 and 4.2.1
  • ? manual correction for 3d @ def2svp etc -- is the order version dependent?

@briling briling marked this pull request as ready for review May 28, 2024 16:11
@briling briling requested a review from YAY-C May 28, 2024 16:12
qstack/orcaio.py Outdated Show resolved Hide resolved
qstack/orcaio.py Outdated Show resolved Hide resolved
Copy link
Contributor

@YAY-C YAY-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks all good to me!

Maybe it's worth to specifying that we only deal with version 400 and 421 (in the doc or so)?
then I'm not an ORCA user, maybe those are the only versions that need special care

@briling
Copy link
Contributor Author

briling commented Jun 7, 2024

Maybe it's worth to specifying that we only deal with version 400 and 421 (in the doc or so)?

Orca versions 4.0.0 and 4.2.1 are available on lc2 and 5.0.4 is on lc3. We may need to access some computations obtained with all of them (recently I had to read some old .scfp file by 4.0.0). As you see from the code, the .scfp/.scfr format has changed between 4.0 and 4.2, and in 5.0 they changed it to .densities. I haven't implemented readers for other versions because don't think we need it & don't want to install them but this can be done.

What would you say in the doc?

Actually I need to check if the .gbw format is the same for all the versions:

  • check .gbw reader @ 4.0.0 and 4.2.1

unless you wanted to do something more than throwing a warn()

I changed one of the warnings to error because it doesn't make sense to change AO order from orca to pyscf or whatever when the original order is wrong. Still, one can load the file without reordering, correct the 3d elements or anything manually and then reorder for pyscf.

Alternatively, I can just add a manual correction for 3d elements @ def2-svp and others.

Also I was thinking about trying to find a .gbw file in the same directory and using the basis set from it,
but it is weird because then you can read orbitals and then you don't need the density files.

What do you think?

@briling briling requested a review from YAY-C June 14, 2024 15:10
@briling
Copy link
Contributor Author

briling commented Sep 24, 2024

@YAY-C do you think I can merge?

@YAY-C
Copy link
Contributor

YAY-C commented Sep 25, 2024

Sorry, I just saw the message!
But yes, I think it's ready for merging 👍

@briling briling merged commit 3f3d3bb into master Sep 26, 2024
2 checks passed
@briling briling deleted the add-orca-gbw branch September 26, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants