add string.py with constants #2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this looks great. Let's add some tests to ensure it actually works? You can put them into |
certik
reviewed
Jun 25, 2024
certik
approved these changes
Jul 25, 2024
certik
approved these changes
Jul 25, 2024
| @@ -0,0 +1,7 @@ | |||
| from string import ascii_lowercase, ascii_letters | |||
|
|
|||
| def test_string(): | |||
There was a problem hiding this comment.
You need to call the function below ;)
There was a problem hiding this comment.
Perhaps one can write a custom flake8 plugin using https://pypi.org/project/flake8-plugin-utils/ that checks all functions that are defined, are being called.
There was a problem hiding this comment.
I don't think it has to be custom. You could probably use ruff, too :)
There was a problem hiding this comment.
LPython itself should give a warning for something like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a few constants copied from
cpythonLib/string.py.