-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of Inheritance and Polymorphic functions #2801
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good. @Thirumalai-Shaktivel if you could also review it, that would be great.
Not sure why the kernel is failing:
It looks like it could be caused by this PR. |
I think the kernel failure is not related to this PR. Edit: It seems related. I will check and report back |
We have to merge this with #2795 before merging as some of the ASR-pass related modifications are present there. |
Can you please rebase the branch with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. It looks great!
I left minor suggestions
Update or rebase this PR and it is good to merge. |
Also, change the PR heading to appropriate description |
Also, let's clean up the commit messages. |
See: #783 (comment), #319 (comment) |
Do I have to remove all the commits in the history? |
@Thirumalai-Shaktivel can you please tell what an appropriate title for this PR would be? |
a689d98
to
437c9fe
Compare
Thanks for the changes. I have set this PR to auto-merge |
437c9fe
to
f42a561
Compare
No description provided.