2.8 update #6
Open
2.8 update #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change Menu and register calls, begin synax changes on StringProperty, EnumProperty move import statements below bl_info (standard practice in addons) rename blendgit.py for directory path install (std practice)
In linux, existing hard links cause a failure. testing that the added file exists resolves.
|
Curious if the conflicts will be resolved and merged here? I'm happy to help with any further migrations to also include support for 2.9 (not that there are many changes vs 2.8x). Regarding the point of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated this for 2.8 which should bring it closer to closing #5
Please Forgive the PR if you intend to maintain 2.7 and 2.8 separately. Some people are doing both for a while and others are forging ahead.
thanks for the initial project! I fell in love with it and feel it is a must have.
Tested/Working on my archlinux workstation. I don't currently have git properly setup in windows for testing, so that still needs to be tested even though all I changed was API references.
In the process of updating, I made a few format and syntax changes to bring it closer to how contrib addons are done for release builds, just in case you wish to try and get it added.
Readme needs updating and possibly top comments/lic info which I always feel slightly awkward changing without the original author's approval.
Only remaining console message I haven't quite sorted is
Warning: 'file.version_control_menu' doesn't contain '_MT_' with prefix & suffixwhich I haven't found the correct way to resolve yet, but it doesn't seem to affect functionality. The message seems to indicate the correct place for
TOPBAR_MT_fileis in the class, though no other 2.8 addons I've seen do this, so I haven't figured out the best approach.