refactor: 주소 변수명 변경

le2sky · Oct 3, 2023 · c6e148f · c6e148f
1 parent d85a9e2
commit c6e148f
Show file tree

Hide file tree

Showing 7 changed files with 18 additions and 18 deletions.
diff --git a/...application/src/test/kotlin/com/mealkitary/shop/application/service/GetShopServiceTest.kt b/...application/src/test/kotlin/com/mealkitary/shop/application/service/GetShopServiceTest.kt
@@ -37,7 +37,7 @@ class GetShopServiceTest : AnnotationSpec() {
                             "region1DepthName",
                             "region2DepthName",
                             "region3DepthName",
-                            "region4DepthName"
+                            "roadName"
                         )
                     ),
                     mutableListOf(),

diff --git a/...on/src/test/kotlin/com/mealkitary/shop/application/service/UpdateShopStatusServiceTest.kt b/...on/src/test/kotlin/com/mealkitary/shop/application/service/UpdateShopStatusServiceTest.kt
@@ -38,7 +38,7 @@ class UpdateShopStatusServiceTest : AnnotationSpec() {
                     "region1DepthName",
                     "region2DepthName",
                     "region3DepthName",
-                    "region4DepthName"
+                    "roadName"
                 )
             ),
             mutableListOf(),
@@ -70,7 +70,7 @@ class UpdateShopStatusServiceTest : AnnotationSpec() {
                     "region1DepthName",
                     "region2DepthName",
                     "region3DepthName",
-                    "region4DepthName"
+                    "roadName"
                 )
             ),
             mutableListOf(),
@@ -102,7 +102,7 @@ class UpdateShopStatusServiceTest : AnnotationSpec() {
                     "region1DepthName",
                     "region2DepthName",
                     "region3DepthName",
-                    "region4DepthName"
+                    "roadName"
                 )
             ),
             mutableListOf(),

diff --git a/mealkitary-domain/src/main/kotlin/com/mealkitary/shop/domain/shop/address/Address.kt b/mealkitary-domain/src/main/kotlin/com/mealkitary/shop/domain/shop/address/Address.kt
@@ -11,23 +11,23 @@ class Address(
     val region2DepthName: String,
     @Column(name = "region_3depth_name")
     val region3DepthName: String,
-    @Column(name = "region_4depth_name")
-    val region4DepthName: String
+    @Column(name = "road_name")
+    val roadName: String
 ) {
 
     companion object {
         fun of(
             region1DepthName: String,
             region2DepthName: String,
             region3DepthName: String,
-            region4DepthName: String
+            roadName: String
         ): Address {
 
             return Address(
                 region1DepthName,
                 region2DepthName,
                 region3DepthName,
-                region4DepthName
+                roadName
             )
         }
     }

diff --git a/mealkitary-domain/src/test/kotlin/com/mealkitary/shop/domain/shop/AddressTest.kt b/mealkitary-domain/src/test/kotlin/com/mealkitary/shop/domain/shop/AddressTest.kt
@@ -11,18 +11,18 @@ class AddressTest : AnnotationSpec() {
         val region1DepthName = "서울"
         val region2DepthName = "강남구"
         val region3DepthName = "논현동"
-        val region4DepthName = "논현로"
+        val roadName = "논현로"
 
         val address = Address.of(
             region1DepthName,
             region2DepthName,
             region3DepthName,
-            region4DepthName
+            roadName
         )
 
         address.region1DepthName shouldBe region1DepthName
         address.region2DepthName shouldBe region2DepthName
         address.region3DepthName shouldBe region3DepthName
-        address.region4DepthName shouldBe region4DepthName
+        address.roadName shouldBe roadName
     }
 }
diff --git a/mealkitary-domain/src/test/kotlin/com/mealkitary/shop/domain/shop/ShopAddressTest.kt b/mealkitary-domain/src/test/kotlin/com/mealkitary/shop/domain/shop/ShopAddressTest.kt
@@ -21,7 +21,7 @@ class ShopAddressTest : AnnotationSpec() {
             "region1DepthName",
             "region2DepthName",
             "region3DepthName",
-            "region4DepthName"
+            "roadName"
         )
 
         val shopAddress = ShopAddress.of(
@@ -46,7 +46,7 @@ class ShopAddressTest : AnnotationSpec() {
             "region1DepthName",
             "region2DepthName",
             "region3DepthName",
-            "region4DepthName"
+            "roadName"
         )
 
         shouldThrow<IllegalArgumentException> {

diff --git a/.../adapter-address-resolver/src/main/kotlin/com/mealkitary/address/SimpleAddressResolver.kt b/.../adapter-address-resolver/src/main/kotlin/com/mealkitary/address/SimpleAddressResolver.kt
@@ -21,7 +21,7 @@ class SimpleAddressResolver : AddressResolver {
         val region1DepthName = value[0]
         val region2DepthName = value[1]
         val region3DepthName = value.getOrNull(2) ?: ""
-        val region4DepthName = value.getOrNull(3) ?: ""
+        val roadName = value.getOrNull(3) ?: ""
 
         // TODO: 좌표 및 지역 코드를 카카오 API에서 받아올 예정
         return ShopAddress.of(
@@ -34,7 +34,7 @@ class SimpleAddressResolver : AddressResolver {
                 region1DepthName,
                 region2DepthName,
                 region3DepthName,
-                region4DepthName
+                roadName
             )
         )
     }

diff --git a/...tary-infrastructure/adapter-address-resolver/src/test/kotlin/SimpleAddressResolverTest.kt b/...tary-infrastructure/adapter-address-resolver/src/test/kotlin/SimpleAddressResolverTest.kt
@@ -22,7 +22,7 @@ class SimpleAddressResolverTest : AnnotationSpec() {
         shopAddress.address.region1DepthName shouldBe "서울특별시"
         shopAddress.address.region2DepthName shouldBe "강남구"
         shopAddress.address.region3DepthName shouldBe "역삼동"
-        shopAddress.address.region4DepthName shouldBe "논현로"
+        shopAddress.address.roadName shouldBe "논현로"
     }
 
     @Test
@@ -38,7 +38,7 @@ class SimpleAddressResolverTest : AnnotationSpec() {
         shopAddress.address.region1DepthName shouldBe "경기도"
         shopAddress.address.region2DepthName shouldBe "남양주시"
         shopAddress.address.region3DepthName shouldBe "다산동"
-        shopAddress.address.region4DepthName shouldBe ""
+        shopAddress.address.roadName shouldBe ""
     }
 
     @Test
@@ -54,7 +54,7 @@ class SimpleAddressResolverTest : AnnotationSpec() {
         shopAddress.address.region1DepthName shouldBe "제주특별자치도"
         shopAddress.address.region2DepthName shouldBe "한림읍"
         shopAddress.address.region3DepthName shouldBe ""
-        shopAddress.address.region4DepthName shouldBe ""
+        shopAddress.address.roadName shouldBe ""
     }
 
     @Test