Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[개선] 가게 생성 시 주소 정보 추가 (issue#79) #82

Merged
merged 13 commits into from
Oct 4, 2023

Conversation

1o18z
Copy link
Collaborator

@1o18z 1o18z commented Oct 3, 2023

구현 요약

  • 가게 생성 시 주소를 함께 입력받도록 작성했습니다.
  • 카카오 api 연동을 통해 세부 주소 정보를 받아오도록 수정할 예정입니다.
  • 중복 파일이 생성되는 문제가 발생하여 api의 build.gradle에 중복 파일을 제거하도록 설정했습니다.

연관 이슈
#79

@1o18z 1o18z added enhancement 뭔가 개선하고 싶어 run: ci ci 과정 실행 해줘~ run: gradle test 테스트 커버리지랑 결과를 알고 싶어 labels Oct 3, 2023
@1o18z
Copy link
Collaborator Author

1o18z commented Oct 3, 2023

@le2sky 코드리뷰 부탁드립니다 !! 🙌🏻🙆🏻‍♀️🙇🏻‍♀️💪🏻

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Test Results

221 tests  +11   221 ✔️ +11   22s ⏱️ -4s
  57 suites +  4       0 💤 ±  0 
  57 files   +  4       0 ±  0 

Results for commit 621ebd7. ± Comparison against base commit 0cad251.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #82 (621ebd7) into develop (0cad251) will increase coverage by 0.32%.
The diff coverage is 98.66%.

@@              Coverage Diff              @@
##             develop      #82      +/-   ##
=============================================
+ Coverage      95.19%   95.51%   +0.32%     
- Complexity       258      278      +20     
=============================================
  Files             60       64       +4     
  Lines            645      714      +69     
  Branches          31       36       +5     
=============================================
+ Hits             614      682      +68     
  Misses            18       18              
- Partials          13       14       +1     
Files Coverage Δ
...lkitary/shop/web/request/RegisterShopWebRequest.kt 100.00% <100.00%> (ø)
...shop/application/port/input/RegisterShopRequest.kt 100.00% <100.00%> (ø)
...ry/shop/application/service/RegisterShopService.kt 100.00% <100.00%> (ø)
...main/kotlin/com/mealkitary/common/model/Address.kt 100.00% <100.00%> (ø)
...ain/kotlin/com/mealkitary/shop/domain/shop/Shop.kt 81.48% <100.00%> (+0.71%) ⬆️
...mealkitary/shop/domain/shop/address/ShopAddress.kt 100.00% <100.00%> (ø)
...mealkitary/shop/domain/shop/factory/ShopFactory.kt 100.00% <100.00%> (ø)
...in/com/mealkitary/address/SimpleAddressResolver.kt 100.00% <100.00%> (ø)
.../kotlin/com/mealkitary/common/model/Coordinates.kt 90.90% <90.90%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@le2sky le2sky removed the run: gradle test 테스트 커버리지랑 결과를 알고 싶어 label Oct 3, 2023
@le2sky le2sky self-requested a review October 3, 2023 16:43
Copy link
Owner

@le2sky le2sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생많으셨습니다! 💯💯 Address, CoordinatesMoney와 비슷하게 여러 곳에서 사용 가능할 것 같으니 shop 내부에 ShopAddress 하나만 유지하고, 나머지(Address, Coordinates)는 아래 경로에 두는 것이 좋아보입니다! 🙇🏻‍♂️

image

@le2sky le2sky merged commit 18b958c into develop Oct 4, 2023
7 checks passed
@le2sky le2sky deleted the refactor/79 branch October 4, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 뭔가 개선하고 싶어 run: ci ci 과정 실행 해줘~
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants