Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[문제] 카카오 주소 검색 API 연동 문제(issue#89) #90

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Conversation

le2sky
Copy link
Owner

@le2sky le2sky commented Oct 12, 2023

구현 요약

  • KaKaoApiAddressResolver에서 사용하는 KaKaoApiWebClient가 정상적으로 동작하지 않아, 신규 가게를 등록할 수 없는 문제를 해결했습니다.
  • 추가적인 검증 로직을 작성했습니다.

연관 이슈
#89

@le2sky le2sky added problem 뭔가 잘못됐어 run: ci ci 과정 실행 해줘~ labels Oct 12, 2023
@le2sky le2sky self-assigned this Oct 12, 2023
@github-actions
Copy link

Test Results

244 tests   244 ✔️  32s ⏱️
  61 suites      0 💤
  61 files        0

Results for commit 86f6097.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #90 (86f6097) into develop (5888426) will increase coverage by 0.18%.
Report is 1 commits behind head on develop.
The diff coverage is 98.63%.

@@              Coverage Diff              @@
##             develop      #90      +/-   ##
=============================================
+ Coverage      96.19%   96.37%   +0.18%     
- Complexity       317      329      +12     
=============================================
  Files             72       72              
  Lines            815      856      +41     
  Branches          38       39       +1     
=============================================
+ Hits             784      825      +41     
  Misses            16       16              
  Partials          15       15              
Files Coverage Δ
...kotlin/com/mealkitary/address/KakaoApiWebClient.kt 100.00% <100.00%> (ø)
...lkitary/address/payload/KakaoApiAddressResponse.kt 100.00% <100.00%> (ø)
.../com/mealkitary/address/KakaoApiAddressResolver.kt 96.77% <96.42%> (+2.65%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link
Owner Author

@le2sky le2sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1o18z 리뷰 부탁드려요! 🙇🏻‍♂️🙇🏻‍♂️

@le2sky le2sky requested a review from 1o18z October 12, 2023 23:12
@1o18z
Copy link
Collaborator

1o18z commented Oct 13, 2023

수고하셨습니다~!~! 1️⃣0️⃣0️⃣✨
메서드 분리.. 너무 편안합니다....🙆🏻‍♀️🥇🙆🏻‍♀️🥇🙆🏻‍♀️

@le2sky le2sky merged commit 99f7c95 into develop Oct 13, 2023
7 checks passed
@le2sky le2sky deleted the fix/89 branch October 13, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
problem 뭔가 잘못됐어 run: ci ci 과정 실행 해줘~
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants