Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump http and dio deps #148

Merged
merged 1 commit into from
Nov 25, 2023
Merged

chore: bump http and dio deps #148

merged 1 commit into from
Nov 25, 2023

Conversation

lexxxel
Copy link
Contributor

@lexxxel lexxxel commented Nov 13, 2023

No description provided.

@lijy91
Copy link
Member

lijy91 commented Nov 25, 2023

LGTM

@lijy91 lijy91 merged commit 26914f0 into leanflutter:main Nov 25, 2023
2 of 3 checks passed
@lijy91
Copy link
Member

lijy91 commented Nov 25, 2023

I have revert this PR, and in order to maintain a minimum compatibility of 2.16, I cannot upgrade Google API to 11.4.0

@lexxxel
Copy link
Contributor Author

lexxxel commented Nov 25, 2023

I have revert this PR, and in order to maintain a minimum compatibility of 2.16, I cannot upgrade Google API to 11.4.0

What do you mean with 2.16? Do you mean dart 2.16?
I ask, because this makes this package incompatible with other packages, e.g. pocketbase.

Typically one could solve this by creating a new major release and still backport/release patches to the older major version, but of course that would increase you maintenance burden.
However, otherwise one would have to fork your project to get said compatibility with other packages.
What is your opinion on that?

@lijy91
Copy link
Member

lijy91 commented Nov 25, 2023

Aren't you installing it globally? It shouldn't affect your own project dependencies.

@lexxxel
Copy link
Contributor Author

lexxxel commented Nov 25, 2023

Aren't you installing it globally? It shouldn't affect your own project dependencies.

No I did not. Thank you for the inside. That will fix my dependency issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants