feat: Switch bvOmegaBench to use MetaM [3/?] #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bollu
changed the title
bollu
force-pushed
the
simp-mem-mem-omega-3
branch
3 times, most recently
from
50ab758 to
cd351d7
Compare
bollu
force-pushed
the
simp-mem-mem-omega-3
branch
from
cd351d7 to
617e32b
Compare
bollu
force-pushed
the
simp-mem-mem-omega-3
branch
from
e2daf44 to
ba6f253
Compare
shigoel
approved these changes
Oct 30, 2024
shigoel
pushed a commit
that referenced
this pull request
Oct 31, 2024
### Description: This ensures that one part of the infrastructure is written completely in terms of MetaM. We will give `simp_mem` the same treatment next. PR stacked on top of #232 ### Testing: No executable defs have changed, cosim succeeds. ### License: By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This allows us to gradually convert all our tactics to
MetaM,which provides the correct level to discipline to make sure
that bugs like #154 don't happen anymore.
Also, as a mild bonus, one hopes that eliminating
evalTacticmakes stuff a bit faster,but I would not hold my breath on this.
Stacked on #231
Testing:
What tests have been run? Did
make allsucceed for your changes? Wasconformance testing successful on an Aarch64 machine?
License:
By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.