This repository has been archived by the owner on Aug 6, 2024. It is now read-only.
feat: added Playwright and created 2 demo tests #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmoesbergen
changed the title
|
awesome! A few initial comments:
|
sverben
reviewed
Mar 29, 2024
…ed because of their lack of webserial support
…educe duplicate setup time and changed to node 20.x
sverben
approved these changes
Apr 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added Playwright and created 2 demo tests.
They are testing that the blink example loads and the code is generated and after changing the delays it is reflected in the code.
The other one tests a old bug where a second robot selection screen would incorrectly show up after loading the editor.