-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move UI translations from content packs to repository #5537
Move UI translations from content packs to repository #5537
Conversation
…older to kalite/project/locale.
…-packs' of https://github.com/mrpau/ka-lite into mrpau-hotfix/5518-move-interface-translations-out-ouf-content-packs
Codecov Report
@@ Coverage Diff @@
## 0.17.x #5537 +/- ##
==========================================
+ Coverage 62.59% 62.71% +0.11%
==========================================
Files 117 117
Lines 6556 6550 -6
==========================================
+ Hits 4104 4108 +4
+ Misses 2452 2442 -10
Continue to review full report at Codecov.
|
This refactor isn't possible to do in 0.17 and if anyone would wanna refactor this codebase, this would be a drop in the ocean :) |
Summary
Taking over from #5524
TODO
If not all TODOs are marked, this PR is considered WIP (work in progress)
Reviewer guidance
This should remove all translation files from content packs, instead fetching them from CrowdIn.
Issues addressed
#5518