Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move UI translations from content packs to repository #5537

Conversation

benjaoming
Copy link
Contributor

Summary

Taking over from #5524

TODO

If not all TODOs are marked, this PR is considered WIP (work in progress)

  • Has documentation been written/updated?
  • Have you written release notes for the upcoming release?

Reviewer guidance

This should remove all translation files from content packs, instead fetching them from CrowdIn.

Issues addressed

#5518

@codecov
Copy link

codecov bot commented Nov 13, 2017

Codecov Report

Merging #5537 into 0.17.x will increase coverage by 0.11%.
The diff coverage is 15.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.17.x    #5537      +/-   ##
==========================================
+ Coverage   62.59%   62.71%   +0.11%     
==========================================
  Files         117      117              
  Lines        6556     6550       -6     
==========================================
+ Hits         4104     4108       +4     
+ Misses       2452     2442      -10
Impacted Files Coverage Δ
kalite/i18n/management/commands/makemessages.py 95.83% <ø> (ø) ⬆️
...nagement/commands/setup_in_context_translations.py 0% <0%> (ø) ⬆️
...tributed/management/commands/contentpackchecker.py 0% <0%> (ø) ⬆️
kalite/i18n/base.py 55.15% <10.52%> (-0.7%) ⬇️
kalite/legacy/i18n_settings.py 86.36% <100%> (ø) ⬆️
...ributed/management/commands/retrievecontentpack.py 51.48% <11.11%> (+3.3%) ⬆️
kalite/project/settings/base.py 87.38% <0%> (-0.69%) ⬇️
kalite/distributed/views.py 78.65% <0%> (ø) ⬆️
kalite/facility/api_views.py 64% <0%> (+10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b2bf2e...c5667a9. Read the comment docs.

@benjaoming
Copy link
Contributor Author

This refactor isn't possible to do in 0.17 and if anyone would wanna refactor this codebase, this would be a drop in the ocean :)

@benjaoming benjaoming closed this Sep 7, 2019
@benjaoming benjaoming deleted the feature/translations-in-repo branch September 7, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants