Fix the CLI --pythonpath parameter #12874
Open
+36
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure we validate pythonpath option before settings option. Set python path for all CLI commands so that it can be used for plugins too.
github-actions
bot
added
the
DEV: backend
Build Artifacts
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References
Fixes #10296
Reviewer guidance
Create a dummy plugin or settings file in a completely different folder. Pass the (can be relative) path to that folder using the the
--pythonpathCLI option when invokingkolibri shellkolibri plugin enableor the like, and ensure that the settings file or plugin can take effect.