Fixes Coach > Lessons - 'Recipients' drop-down not working

[AllanOXDi]

Summary

This PR fixes Coach > Lesson where the 'Recipients' dropdown values does not show.

please not that when you navigate to Coach > Quizzes and select a value from the 'Recipients' drop-down you will either see a scroll-bar or the contents of the drop-down are not fully visible is an issue with KSelect which is being track by this learningequality/kolibri-design-system#690

References

closes #12898

Reviewer guidance

Navigate to coach > lesson and filter learners by names or entire class

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.18.0a0.dev0_git.106.g0129fed8.pex
Windows Installer (EXE)	kolibri-0.18.0a0.dev0+git.106.g0129fed8-windows-setup-unsigned.exe
Debian Package	kolibri_0.18.0a0.dev0+git.106.g0129fed8-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.18.0a0.dev0+git.106.g0129fed8.dmg
Android Package (APK)	kolibri-0.18.0a0.dev0+git.106.g0129fed8-0.1.4-debug.apk
TAR file	kolibri-0.18.0a0.dev0+git.106.g0129fed8.tar.gz
WHL file	kolibri-0.18.0a0.dev0+git.106.g0129fed8-py2.py3-none-any.whl

[pcenov]

Hi @AllanOXDi - I confirm that now the recipients are displayed in the 'Recipients' drop-down at Coach > Learners, however as I have mentioned in #12898 the drop-down is either causing a scroll-bar at the frame or is being displayed upwards. Also the 'Recipients' drop-down is not working at Coach > Learners as well:

2024-12-06_12-24-07.mp4

Let me know if these issues can be addressed here or I should file follow-up issues. Thanks!

[AllanOXDi]

thanks @pcenov . I highly think the other part you raised is related to this. We can file a follow up issue and come back to it once it's fixed.

[pcenov]

Hi @AllanOXDi if the issue with the KSelect’s dropdown being displayed above the input is tracked in learningequality/kolibri-design-system#690 then we don't need to file another issue for it, right?
Will you be fixing here the issue with the 'Recipients' drop-down not working at Coach > Learners - looking closely at it, it probably should be removed or changed to something else actually?

[AllanOXDi]

Will you be fixing here the issue with the 'Recipients' drop-down not working at Coach > Learners?

Yes @pcenov, Let me do so now. Thanks

[pcenov]

I think someone has added that 'Recipients' drop-down there by mistake, so it should first be clarified why is that drop-down there and what should be the actual filter on that page. On my end I'll approve this PR as it addresses the main issue.

[ozer550]

Hi @AllanOXDi if the issue with the KSelect’s dropdown being displayed above the input is tracked in learningequality/kolibri-design-system#690 then we don't need to file another issue for it, right? Will you be fixing here the issue with the 'Recipients' drop-down not working at Coach > Learners - looking closely at it, it probably should be removed or changed to something else actually?

Hi @pcenov, I have fixed the filtering part for Coach->Learners in the PR that I am currently working on related with csv export functionality mentioned in the issue here. Could you review it there once I open the PR.

[pcenov]

Certainly @ozer550 - thanks for letting me know!

[LianaHarris360]

The code logic makes sense and look good to me, thanks Allan!