Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix snackbar errors in content import #12946

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix snackbar errors in content import #12946

wants to merge 1 commit into from
+5 −7

Conversation

rtibbles
Copy link
Member

Summary

  • Regression caused by Vue 2.7 upgrade
  • Use the composable in module scope, as can't define setup on a mixin if the consuming component also defines setup.

References

Follow up from #12933

Reviewer guidance

Import content into Kolibri, confirm that snackbars are displayed, without errors, and that redirects happen properly

@rtibbles
Use the composable in module scope, as can't define setup on a mixin …
74dcc1a 
…if the consuming component also defines setup.
@github-actions github-actions bot added APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) DEV: frontend labels Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Build Artifacts

Asset type Download link
PEX file kolibri-0.18.0a0.dev0_git.150.g751d70c6.pex
Windows Installer (EXE) kolibri-0.18.0a0.dev0+git.150.g751d70c6-windows-setup-unsigned.exe
Debian Package kolibri_0.18.0a0.dev0+git.150.g751d70c6-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.18.0a0.dev0+git.150.g751d70c6.dmg
Android Package (APK) kolibri-0.18.0a0.dev0+git.150.g751d70c6-0.1.4-debug.apk
Raspberry Pi Image kolibri-pi-image-0.18.0a0.dev0+git.150.g751d70c6.zip
TAR file kolibri-0.18.0a0.dev0+git.150.g751d70c6.tar.gz
WHL file kolibri-0.18.0a0.dev0+git.150.g751d70c6-py2.py3-none-any.whl

nucleogenesis
nucleogenesis reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@nucleogenesis nucleogenesis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get the "Task finished" snackbar but I don't suspect that is related to your changes here.

I have a video but GH isn't uploading it correctly ping me on Slack if you want it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nucleogenesis nucleogenesis nucleogenesis left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) DEV: frontend
Projects
None yet
Milestone
Kolibri 0.18: General maintenance
Development

Successfully merging this pull request may close these issues.
2 participants
@rtibbles @nucleogenesis