Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link in old wallet 4.10.1 (or older) "update available" doesn't work #1220

Closed
314159265359879 opened this issue Sep 3, 2023 · 4 comments · Fixed by #1228
Closed

Link in old wallet 4.10.1 (or older) "update available" doesn't work #1220

314159265359879 opened this issue Sep 3, 2023 · 4 comments · Fixed by #1228
Assignees
@pete-watters
Labels
Bug 🐛 Functionality broken P1 Bug 🚨 Critical functionality broken for many customers, with no clear workarounds

Comments

@314159265359879
Copy link

image

It would be great if this worked, users are careful when it comes to this, anything we can do to make the old link redirect to the new wallet?

image
@314159265359879 314159265359879 added Bug 🐛 Functionality broken P1 Bug 🚨 Critical functionality broken for many customers, with no clear workarounds labels Sep 3, 2023
@DeeList
Copy link

DeeList commented Sep 4, 2023

Hiro Wallet Desktop v4.10.1 - User reported 'Update Available' link clicked at top of screen leads to incorrect page. Link leads to old site https://www.hiro.so/wallet/install-desktop. I was able to confirm this issue.

update link dead

@314159265359879
Copy link
Author

Thanks for confirming I have asked Rena if this can be fixed with a redirect from Hiro.so

@DeeList
Copy link

DeeList commented Sep 5, 2023

I don't have permission to link this issue with pr #1223

@pete-watters pete-watters self-assigned this Sep 5, 2023
@pete-watters pete-watters linked a pull request Sep 5, 2023 that will close this issue
fix(title-bar): correct broken link #1223
Closed
@314159265359879
Copy link
Author

Thanks for writing the fix for this @pete-watters for future versions. Hiro has also created a redirect now so users with the old versions end up in the right place to download the latest wallet.

pete-watters added a commit that referenced this issue Sep 19, 2023
@pete-watters
fix: update link to leather-wallet desktop download, closes #1220
749d20b
@pete-watters pete-watters mentioned this issue Sep 19, 2023
Merged
@pete-watters pete-watters linked a pull request Sep 19, 2023 that will close this issue
fix: 1220, 1221 - typo in wallet and download link #1228
Merged
kyranjamie pushed a commit that referenced this issue Sep 19, 2023
@pete-watters @kyranjamie
fix: update link to leather-wallet desktop download, closes #1220
4795a21
kyranjamie pushed a commit that referenced this issue Sep 19, 2023
@pete-watters @kyranjamie
fix: update link to leather-wallet desktop download, closes #1220
4cd64ac
kyranjamie pushed a commit that referenced this issue Sep 19, 2023
@semantic-release-bot
chore(release): 4.14.1-dev.1
d864781 
## [4.14.1-dev.1](v4.14.0...v4.14.1-dev.1) (2023-09-19)

### Bug Fixes

* fix typo in leather-wallet, closes [#1221](#1221) ([66b8efa](66b8efa))
* update link to leather-wallet desktop download, closes [#1220](#1220) ([4cd64ac](4cd64ac))
kyranjamie pushed a commit that referenced this issue Sep 20, 2023
@semantic-release-bot
chore(release): 4.14.1
e87a326 
## [4.14.1](v4.14.0...v4.14.1) (2023-09-20)

### Bug Fixes

* fix typo in leather-wallet, closes [#1221](#1221) ([66b8efa](66b8efa))
* update link to leather-wallet desktop download, closes [#1220](#1220) ([4cd64ac](4cd64ac))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pete-watters pete-watters

Labels
Bug 🐛 Functionality broken P1 Bug 🚨 Critical functionality broken for many customers, with no clear workarounds
Projects
None yet
Milestone
No milestone
3 participants
@pete-watters @314159265359879 @DeeList