Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(title-bar): correct broken link #1223

Closed
wants to merge 1 commit into from
Closed

fix(title-bar): correct broken link #1223

wants to merge 1 commit into from

Conversation

DeeList
Copy link

@DeeList DeeList commented Sep 5, 2023

change 'Update Available' url

@DeeList DeeList mentioned this pull request Sep 5, 2023
Closed
@pete-watters pete-watters linked an issue Sep 5, 2023 that may be closed by this pull request
Link in old wallet 4.10.1 (or older) "update available" doesn't work #1220
Closed
pete-watters
pete-watters approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@pete-watters pete-watters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DeeList

kyranjamie
kyranjamie approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@kyranjamie kyranjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kyranjamie
Copy link
Collaborator

Can you reword commit to match conventional commit format?

@DeeList DeeList changed the title Update title-bar.tsx fix(title-bar): correct broken link Sep 12, 2023
@DeeList
fix(title-bar): correct broken link
335becb 
change 'Update Available' url
@markmhendrickson
Copy link
Collaborator

@DeeList the dev 💪

@markmhendrickson
Copy link
Collaborator

@pete-watters to merge into dev but not cut separate release

@pete-watters
Copy link
Contributor

Thanks for fixing this @DeeList 👍

I had to take your change into a new branch - #1228 so I will close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pete-watters pete-watters pete-watters approved these changes

@kyranjamie kyranjamie Awaiting requested review from kyranjamie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link in old wallet 4.10.1 (or older) "update available" doesn't work
4 participants
@DeeList @kyranjamie @markmhendrickson @pete-watters