-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
October updates #156
October updates #156
Conversation
@friedger is attempting to deploy a commit to the Trust Machines Team on Vercel. To accomplish this, @friedger needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
This depends on hirosystems/connect#339 |
@friedger it looks like we can get this one merged now that hirosystems/connect#339 is merged? |
@markmhendrickson Yes, I just pushed the commit with the latest version |
@friedger I'm not sure if I should file as a separate issue or if you want to resolve as part of this PR, but this weekend I was extending my Stacking and found that the modal would throw a validation error (telling me I couldn't stack X number of more cycles) if I'd selected more than Unfortunately I didn't get a good screenshot. Might you want to check the logic here? |
@markmhendrickson What is the resolution? Could you clarify |
Relevant scenario:
|
@friedger Let's get this PR released and we can tackle the Stacking bug reported above in the comments separately? |
I have opened a new issue on connect: hirosystems/connect#342 |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@friedger @kyranjamie let's get this shipped and closed out? |
Now you have permissions, if you rebase @friedger do you get a ✅ |
Ok, I'll do. |
This PR
Testing
Fix end cycle for extend-stacking
Remove links
Update Connect library
TODO