Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design system - Typography update #72

Open
mica000 opened this issue Feb 26, 2024 · 11 comments
Open

Design system - Typography update #72

mica000 opened this issue Feb 26, 2024 · 11 comments

Comments

@mica000
Copy link

mica000 commented Feb 26, 2024

This ticket is to update the typography scale to cover @fbwoolf comment:
"We used to have a Title component in stacks/ui, so when we did the refactor we did make one using label01 atm to make the refactor easier. We could remove it and just style each piece of text separately, or we could update that component to share across the wallet still. It seems it should be label02 though and checked where used. Also, currently our label02 doesn NOT have a fontWeight of 500, so that needs to be changed. My thought is that with a separate coordination issue typography overall should be revisited again llke we did for colors."

https://www.figma.com/file/2MLHeIeL6XPVi3Tc2DfFCr/%E2%9D%96-Leather-%E2%80%93-Design-System?type=design&node-id=1257-1463&mode=design

image

@kyranjamie
Copy link
Collaborator

Migrating to monorepo

@kyranjamie kyranjamie transferred this issue from leather-io/extension Feb 29, 2024
@kyranjamie
Copy link
Collaborator

This is an important one for us to get done. Is it ready for development @mica000 ?

@mica000
Copy link
Author

mica000 commented Mar 1, 2024

@fabric-8 curious on your take in regards to Caption02 - it's not very crispy but I added it here to cover to the old typography system we had to avoid things breaking when launching the rebrand - it's not particularly in use by the new designs system, shall we remove it?

@fabric-8
Copy link
Contributor

fabric-8 commented Mar 1, 2024

Yes I think it's fine to remove 👍

@mica000
Copy link
Author

mica000 commented Mar 1, 2024

@fabric-8 @kyranjamie Also added the font we use for code in there.

@mica000
Copy link
Author

mica000 commented Mar 11, 2024

There is on more change we need to make which is to merge Body02 and Caption 01.

Context:
The old designs system had these in the scale so I preserved them during rebranding to avoid breaking the layout however body02 and caption 01 were the same. This wasn't good so they are now merged. This means that now we have only 1 size for Body and 1 size for Caption. See design

On the design system in Figma I already replaced the old Body02 for caption 01 (now new Caption). Components Where it was replaced:
• Call out
• Input
• Tooltip

On development, Kyran suggested:
[x] Finalise the typography in Figma, removing the duplicate entry. First principals: what typography do we want? No legacy design system decisions should influence our new design system.
[ ] Remove all fontWeight definitions across the whole product in one find replace.
[ ] Dev and designer live pair together going through all UI flows, fixing what's broken on the spot

Here is the new scale
image

cc @kyranjamie @fabric-8

@fbwoolf
Copy link
Contributor

fbwoolf commented Mar 11, 2024

@edgarkhanzadian you are working on this, correct?

@edgarkhanzadian
Copy link
Collaborator

@fbwoolf oh right this should be closed, i merged it with this pr: #75

@edgarkhanzadian edgarkhanzadian self-assigned this Mar 11, 2024
@kyranjamie
Copy link
Collaborator

@edgarkhanzadian there were new updates from @mica000 since then

@edgarkhanzadian
Copy link
Collaborator

Oh didn't notice it, thank you! Will address those next

@kyranjamie kyranjamie added this to the Urgent monorepo needs milestone Apr 8, 2024
@kyranjamie kyranjamie removed this from the Urgent monorepo needs milestone May 16, 2024
@markmhendrickson
Copy link

@edgarkhanzadian should this be moved back to the backlog if it's not being worked on actively?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants