-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design system - Typography update #72
Comments
Migrating to monorepo |
This is an important one for us to get done. Is it ready for development @mica000 ? |
@fabric-8 curious on your take in regards to Caption02 - it's not very crispy but I added it here to cover to the old typography system we had to avoid things breaking when launching the rebrand - it's not particularly in use by the new designs system, shall we remove it? |
Yes I think it's fine to remove 👍 |
@fabric-8 @kyranjamie Also added the font we use for code in there. |
There is on more change we need to make which is to merge Body02 and Caption 01. Context: On the design system in Figma I already replaced the old Body02 for caption 01 (now new Caption). Components Where it was replaced: On development, Kyran suggested: |
@edgarkhanzadian you are working on this, correct? |
@edgarkhanzadian there were new updates from @mica000 since then |
Oh didn't notice it, thank you! Will address those next |
@edgarkhanzadian should this be moved back to the backlog if it's not being worked on actively? |
This ticket is to update the typography scale to cover @fbwoolf comment:
"We used to have a Title component in stacks/ui, so when we did the refactor we did make one using label01 atm to make the refactor easier. We could remove it and just style each piece of text separately, or we could update that component to share across the wallet still. It seems it should be label02 though and checked where used. Also, currently our label02 doesn NOT have a fontWeight of 500, so that needs to be changed. My thought is that with a separate coordination issue typography overall should be revisited again llke we did for colors."
https://www.figma.com/file/2MLHeIeL6XPVi3Tc2DfFCr/%E2%9D%96-Leather-%E2%80%93-Design-System?type=design&node-id=1257-1463&mode=design
The text was updated successfully, but these errors were encountered: