-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add AddressDisplayer for mobile, closes LEA-1638 #603
Conversation
packages/ui/src/components/address-displayer/address-displayer.native.tsx
Show resolved
Hide resolved
packages/ui/src/components/address-displayer/address-displayer.native.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/components/address-displayer/address-displayer.web.tsx
Outdated
Show resolved
Hide resolved
@kyranjamie Missed an important part: extension will likely need a small PR to address the changes to the component here. Two questions:
|
No, and I didn't realise they were copied. We shouldn't have duplicates of this file, ideally the base.css in the extension reads this one in the mono.
This is a mostly manual process currently. Suggest linking the packages locally, making a PR in the extension (with a broken build because the package hasn't been released yet), then updating the PR when you've released the monorepo changes. |
d081221
to
adbf57f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #603 +/- ##
=======================================
Coverage 24.23% 24.23%
=======================================
Files 155 155
Lines 5847 5847
Branches 324 324
=======================================
Hits 1417 1417
Misses 4430 4430
|
adbf57f
to
90ba3ab
Compare
90ba3ab
to
6c2c92f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work here @tigranpetrossian , this is a really clean and valuable PR 🚀
If you run pnpm syncpack:format
it should fix your lint error
When originally building the UI package we decided against hosting the font files and static assets in there and instead keeping them local to the It could be better to remove that duplication and keep everything in the UI library but we would need to do some work on bundling the font files for export with the UI package. We also have other static assets in |
Thanks! Did this and it seems fine. I suspect the errors are either because I either modified the history of the branch too much or we need to add a |
@pete-watters Agreed. I'm looking into this. If it turns out to be too complicated we'll tackle it separately or worst case scenario stick with duplication. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing ! 🚀
I've flagged a few more lines that prebuild has automatically added to the ios folder.
8e68d02
to
4beca3b
Compare
4beca3b
to
268b06b
Compare
packages/ui/src/components/address-displayer/address-displayer.native.stories.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm @tigranpetrossian 👍
f1d799c
to
7acca95
Compare
I saw this was sitting in the merge queue for ~6 hours. Not sure what is going on but tried removing/readding it. |
Trying again. |
Adds native version of AddressDisplayer, adds Fira Code and addresses some minor font/styling issues as a prerequisite:
address
textStyle to tokens, ascode
that's currently used for the web version of the AddressDisplayer doesn't match the new designs. I'm not extremely happy with the text style name this specific, brought this up with the design team to see if it's worth using something more generic.1ch
wide gaps to avoid trailing spaces.@edgarkhanzadian I would really appreciate your help double checking the config and all the artifacts expo generated after running
prebuild
to bundle fonts. I'm way out of my depth when it comes to this kind of thing.