feat: add sheet animation #622
Draft
+125
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #622 +/- ##
=======================================
Coverage 23.81% 23.81%
=======================================
Files 165 165
Lines 6151 6151
Branches 335 335
=======================================
Hits 1465 1465
Misses 4686 4686
|
alter-eggo
force-pushed
the
feat/add-sheet-animation
branch
from
bacc60d
to
c49a809
Compare
camerow
reviewed
Nov 20, 2024
| @@ -23,14 +23,17 @@ const meta: Meta<typeof Component> = { | |||
| export default meta; | |||
|
|
|||
| export function Sheet() { | |||
| const [isShowing, setIsShowing] = useState(false); | |||
| const triggerRef = useRef<HTMLButtonElement>(null); | |||
There was a problem hiding this comment.
This may be un-wise, but what do you think about Sheet exporting a hook like useSheet which returns functions around the refs, eg { triggerSheet, closeSheet } = useSheet(). Feels to me like Sheet should better encapsulate it's behaviors. Just a thought.
Really loving the animation!
camerow
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds
Screen.Recording.2024-11-15.at.13.12.33.mov