Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated DSP routines #16

Merged
merged 14 commits into from
Oct 4, 2023
Merged

Updated DSP routines #16

merged 14 commits into from
Oct 4, 2023

Conversation

theHenks
Copy link
Collaborator

@theHenks theHenks commented Oct 3, 2023

Updated DSP routines with a preliminary status. ICPC routines and small DSP routines for optimization matters are working stable, but might need some updates, especially for sepcial detector routines or other things. Also, I need to put certain subroutines in subfunctions so that the code is more clear here.
@oschulz could you check the Project.toml so that everything is correct here with julia 1.9 and so?

@theHenks theHenks requested a review from oschulz October 3, 2023 16:28
@oschulz
Copy link
Contributor

oschulz commented Oct 3, 2023

Let's just require Julia v1.9 (in deps and CI).

@oschulz
Copy link
Contributor

oschulz commented Oct 3, 2023

Look good to me in general (except for the test failures ;-) ).

@theHenks
Copy link
Collaborator Author

theHenks commented Oct 3, 2023

Look good to me in general (except for the test failures ;-) ).

It is preliminary, but a release 😅
I am working on updates especially to take subroutines you use more often into separate functions.

@theHenks theHenks merged commit 64fe506 into main Oct 4, 2023
7 checks passed
@theHenks theHenks deleted the dev-florian branch October 4, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants