Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update naming for query params #528

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Update naming for query params #528

merged 1 commit into from
Sep 15, 2023

Conversation

desfero
Copy link
Collaborator

@desfero desfero commented Sep 15, 2023

No description provided.

@desfero desfero self-assigned this Sep 15, 2023
@height
Copy link

height bot commented Sep 15, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9439c82

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lens-sdk-example-web-wagmi ✅ Ready (Inspect) Visit Preview Sep 15, 2023 4:06pm

@desfero desfero force-pushed the fix/update-naming-for-query-params branch from c92cccb to 9439c82 Compare September 15, 2023 16:04
cesarenaldi
cesarenaldi reviewed Sep 15, 2023
View reviewed changes
packages/client/src/submodules/transaction/Transaction.ts
@@ -57,7 +57,7 @@ export class Transaction {
}

async txIdToTxHash(txId: string): Promise<string | null> {
const result = await this.sdk.TxIdToTxHash({ txId });
const result = await this.sdk.TxIdToTxHash({ for: txId });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does this work now? I mean the query

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it accept a string that is either an hash or an id?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no only a tx id

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh... ignore me... confused it for "wait for"

@desfero desfero changed the title [Do not merge] Update naming for query params Update naming for query params Sep 15, 2023
@desfero desfero merged commit 3928c8d into lens-v2 Sep 15, 2023
1 check passed
@desfero desfero deleted the fix/update-naming-for-query-params branch September 15, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesarenaldi cesarenaldi cesarenaldi left review comments

@joshstevens19 joshstevens19 joshstevens19 approved these changes

Assignees

@desfero desfero

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@desfero @cesarenaldi @joshstevens19