Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: suspense support for useProfile hook #916

Merged
merged 7 commits into from
Apr 24, 2024

Conversation

cesarenaldi
Copy link
Member

No description provided.

Copy link

height bot commented Apr 17, 2024

This pull request has been linked to 1 task:

💡Tip: Add "Close T-20005" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

Copy link

changeset-bot bot commented Apr 17, 2024

🦋 Changeset detected

Latest commit: 922615d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@lens-protocol/react Minor
@lens-protocol/react-native Minor
@lens-protocol/react-web Minor
@lens-protocol/wagmi Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lens-sdk-example-web-wagmi ✅ Ready (Inspect) Visit Preview Apr 24, 2024 11:52am

@cesarenaldi cesarenaldi marked this pull request as ready for review April 23, 2024 15:21
if (error) return <ErrorMessage error={error} />;
<label>
lens/
<input type="text" name="localName" defaultValue={localName} onChange={update} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a note: this approach triggers api call on each key press

Copy link
Contributor

@krzysu krzysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry but I found something now, the type is not resolved correctly if I remove new suspense flag from the hook

Screenshot 2024-04-24 at 15 06 31

Copy link
Contributor

@krzysu krzysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, my bad, somehow I didn't have the latest version on my local branch

@cesarenaldi cesarenaldi merged commit 8d4e958 into develop Apr 24, 2024
6 checks passed
@cesarenaldi cesarenaldi deleted the T-20005/useProfile-suspense branch April 24, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants