Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples/build): do not require stop to end trunk #1713

Merged
merged 2 commits into from
Sep 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/cargo-make/client-process.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ condition = { env_set = ["CLIENT_PROCESS_NAME"] }
script = '''
if [ -z $(pidof ${CLIENT_PROCESS_NAME}) ]; then
echo " Starting ${CLIENT_PROCESS_NAME}"
cargo make start-client ${@} &
cargo make start-client ${@}
else
echo " ${CLIENT_PROCESS_NAME} is already started"
fi
Expand Down
4 changes: 4 additions & 0 deletions examples/cargo-make/server-process.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,12 @@ script = '''
[tasks.maybe-start-server]
condition = { env_set = ["SERVER_PROCESS_NAME"] }
script = '''
YELLOW="\e[0;33m"
RESET="\e[0m"

if [ -z $(pidof ${SERVER_PROCESS_NAME}) ]; then
echo " Starting ${SERVER_PROCESS_NAME}"
echo " ${YELLOW}>> Run cargo make stop to end process${RESET}"
cargo make start-server ${@} &
else
echo " ${SERVER_PROCESS_NAME} is already started"
Expand Down
2 changes: 2 additions & 0 deletions examples/login_with_token_csr_only/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,5 @@ The `api-boundary` crate contains data structures that are used by the server an
## Getting Started

See the [Examples README](../README.md) for setup and run instructions.

You will also need to run `cargo make stop` to end the server process.