fix: Rust-Analyzer hover information / redundant spans #2836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this at all related to this PR: #2835 ? |
I believe entirely unrelated. My changes are around the builder pattern that is constructed in the view macro, theirs is about the |
|
There are pictures available on #2840 that mostly show the improvements. Obviously the code is different but the results are visually similar |
Per https://docs.rs/quote/latest/quote/macro.quote.html#hygiene regarding token hygiene. > Any interpolated tokens preserve the Span information provided by their > `ToTokens` implementation. In many instances, the procedural macros are spanning tokens with their own span redundantly.
chrisp60
force-pushed
the
fix-proc-macro-spans-ra
branch
from
78d6c86 to
e76b759
Compare
|
Thanks very much! Yes, as I understand it #2289 introduced some of these, but rust-analyzer later made changes that caused overlapping spans to break. Thank you for working to clean up the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes hope to improve (I wish I could say fix, but I'm not entirely sure yet) the recent issues that the
view!and#[component]macros had with providing incorrect / extra information through Rust-Analyzer.In many instances, the procedural macros are spanning tokens with their own span redundantly, while also including lint attributes and unrelated tokens within their spanned interpolation.
I am far from an expert on procedural macros and token spans, while this seems to fix the issues on my editor, I just don't know enough to say if it actually fixes everything. From what I can tell, no diagnostic information is lost from these changes.
Additionally, I have no idea how to write a test for this. I am open to doing additional work to research and write tests if needed.