-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add py3.12 #286
add py3.12 #286
Conversation
oh wow, that was quick. unfortunately i'm not sure this is enough. made a temp commit to test the wheel building https://github.com/davidszotten/pylibmc/actions/runs/6480516499/job/17596188708 and it's not building for 3.12. working to figure out why (unless you know?) |
ISTM that cibuildwheel is what is actually creating per-version wheels, and it is not generating an artifact for Python 3.12. |
According to its documentation:
According to the build log:
I think it is because the CD script is using Python 3.7 and cibuildwheel is no longer being released for that ancient version. |
thanks, was just discovering the same thing. since 3.7 is eol, what do you think about dropping support for it? |
actually, maybe it's enough to stop building wheels for 3.7 (by running cibuildwheel on 3.8). testing that now. we may of course still want to stop supporting eol pythons |
ok that seems to work. how does publishing work atm? the upload part is commented out in the workflow |
I upload it manually |
is anything else needed to get a python 3.12 wheel? thanks!