Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logging of contact email addresses #7833

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove logging of contact email addresses #7833

wants to merge 3 commits into from

Conversation

aarongable
Copy link
Contributor

Fixes #7801

@aarongable aarongable requested a review from a team as a code owner November 20, 2024 21:26
@aarongable aarongable requested a review from jsha November 20, 2024 21:26
jsha
jsha requested changes Nov 21, 2024
View reviewed changes
policy/pa.go Show resolved Hide resolved
cmd/expiration-mailer/main.go Outdated Show resolved Hide resolved
cmd/bad-key-revoker/main.go Outdated Show resolved Hide resolved
beautifulentropy
beautifulentropy approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@beautifulentropy beautifulentropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great job. There are so many places that an email could have ended up in an error surfaced in our logs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beautifulentropy beautifulentropy beautifulentropy approved these changes

@jprenken jprenken jprenken approved these changes

@jsha jsha Awaiting requested review from jsha

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce logging of email addresses
4 participants
@aarongable @jsha @jprenken @beautifulentropy