-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change readme install instructions #243
Merged
PhiSpel
merged 69 commits into
master
from
234-feature-change-readme-install-instructions
Aug 28, 2024
Merged
change readme install instructions #243
PhiSpel
merged 69 commits into
master
from
234-feature-change-readme-install-instructions
Aug 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed dirty lettuce from requirements
my best bet for installation:
for now:
to tidy up:
|
|
…d note in readme removed cudatoolkit from requirements.txt and added note in readme added fixation to all required packages sortet requirements by name removed version restrictions from setup.py
use conda for installation
remove `with`s in setup-miniconda
…stall-instructions' into 234-feature-change-readme-install-instructions
changed 'torch' to 'pytorch' and upgraded test to python 3.12
add pytorch-cuda to test for ubuntu and windows
…stall-instructions' into 234-feature-change-readme-install-instructions
auto update conda and setup with correct python version
do not auto-activate base
display conda infos
…stall-instructions' into 234-feature-change-readme-install-instructions
removed test import
…stall-instructions' into 234-feature-change-readme-install-instructions
PhiSpel
changed the title
234 feature change readme install instructions
feature change readme install instructions
Aug 26, 2024
run all tests on same bash
compare with non-changable installation
ignoring pep8 for correct line breaks added pep518 standard for pip setup.py
McBs
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
fixing CI to pytorch 2.4
PhiSpel
changed the title
feature change readme install instructions
change readme install instructions
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
~=
) are not recognized by CondaCUDA_HOME
variable for native (to the package folder.../cudatoolkit_*
containing/bin/nvcc
)closes #170
closes #234
Checklist