-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Split WebSocket support into separate sync/async implementations #449
Open
dolfies
wants to merge
19
commits into
lexiforest:main
Choose a base branch
from
dolfies:feature/wsrfctr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,580
−798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolfies
changed the title
Refactor WebSocket support into separate sync/async implementations
refactor: Split WebSocket support into separate sync/async implementations
Dec 1, 2024
Looks good, please let me know when the PR is ready for review. |
Should be ready! |
Could you please update the websocket section on README and the websocket examples in |
Done |
lexiforest
reviewed
Dec 3, 2024
LGTM, I will have a few trivial API adjustment and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #206, which went stale after I got quite busy. Addresses #202 WebSocket requests (fixes #202, fixes #270).
CurlOpt.CONNECT_ONLY
value, so the session becomes useless if a WebSocket is created from it