[WIP] refactoring pkg/expect #1014
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
return error and let the user handle it the way they want, instead of exiting the program by calling log.Fatal(). Signed-off-by: Shahriyar Jalayeri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return error and let the user handle it the way they want, instead of exiting the program by calling
log.Fatal().Otherwise it makes causes some unexpected situations, for example
PodDeployreturns an error but due to call to some functions fromexpectpackage, it might cause the program tolog.Fatal()exit in the middle of the execution, robbing the caller of a decision on how to handle the error, for example change the app settings and try again.