Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to buildkit 0.13 series for dockerfile-from-checker #15

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

deitch
Copy link
Contributor

@deitch deitch commented Feb 1, 2024

Currently using 0.11.x series. Should move to 0.12.x, but there are compatibility issues with docker/docker, which would require downgrading that to a beta release of 24.0.0 from its current actual 24.0.7. Buildkit v0.13.x is compatible with released docker/docker 25.0.0, so everything works well.

And we already do it for dockerfile-add-scanner anyways.

Signed-off-by: Avi Deitcher <[email protected]>
@deitch
Copy link
Contributor Author

deitch commented Feb 1, 2024

yetus is just wrong here. I do not care what make version is in there. Ignoring.

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume we should move forward from the beta as soon as there is a new release.

FWIW why did you want to remove the make version? I wouldn't expect different versions to cause different built artifacts but locking down the versions of everything seems to have less risk of breaking the reproducibility of the builds.

@deitch
Copy link
Contributor Author

deitch commented Feb 1, 2024

LGTM. I assume we should move forward from the beta as soon as there is a new release.

Sure.

FWIW why did you want to remove the make version? I wouldn't expect different versions to cause different built artifacts but locking down the versions of everything seems to have less risk of breaking the reproducibility of the builds

Then you have to change it with each time you update something. I had it locked to the alpine-3.18 version, and then had to change it for this. It adds no value.

@deitch deitch merged commit 0646e5a into lf-edge:main Feb 1, 2024
5 of 7 checks passed
@deitch deitch deleted the buildkit-013 branch February 1, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants