Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sudo to download instructions #171

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Added sudo to download instructions #171

merged 3 commits into from
Oct 19, 2023

Conversation

edwardalee
Copy link
Contributor

On MacOS Sonoma, at least, the Epoch install script has to be run with sudo.

@edwardalee edwardalee requested a review from lhstrh October 3, 2023 21:38
@lhstrh
Copy link
Member

lhstrh commented Oct 3, 2023

I had a more general solution in mind where we check for write access, and only if sudo is required we prompt for it. I don't think that asking folks to use sudo in the general instructions is a good idea... This can make it subsequently difficult to update or uninstall things, too. Once you opt for sudo, you're basically stuck with it.

@edwardalee
Copy link
Contributor Author

I had a more general solution in mind where we check for write access, and only if sudo is required we prompt for it. I don't think that asking folks to use sudo in the general instructions is a good idea... This can make it subsequently difficult to update or uninstall things, too. Once you opt for sudo, you're basically stuck with it.

Yes, I agree this would be better. Right now, however, our instructions don't work.

@lhstrh
Copy link
Member

lhstrh commented Oct 4, 2023

I realize that, but I imagine that a Mac user would understand a permission error and would know how to resolve it... If we want a quick fix, I'd suggest we instead use a different default prefix: ~/.local (we use the same on Linux) that should be writable by the user.

@edwardalee
Copy link
Contributor Author

I realize that, but I imagine that a Mac user would understand a permission error and would know how to resolve it... If we want a quick fix, I'd suggest we instead use a different default prefix: ~/.local (we use the same on Linux) that should be writable by the user.

Ok, I've pushed a refinement to the instructions. However, they are still not clear. Is the default prefix /usr/local or /usr/local/bin? What exactly should be specified with the --prefix option? Should it be in quotes? Can you clarify this @lhstrh ? Thanks.

@edwardalee
Copy link
Contributor Author

I'm merging these updated instructions because the instructions as they appear don't actually work and it's better to have imperfect instructions that work than to have instructions that don't work.

@edwardalee edwardalee merged commit c00f278 into main Oct 19, 2023
1 check passed
@edwardalee edwardalee deleted the sudo-instructions branch October 19, 2023 17:25
@lhstrh
Copy link
Member

lhstrh commented Oct 19, 2023

I realize that, but I imagine that a Mac user would understand a permission error and would know how to resolve it... If we want a quick fix, I'd suggest we instead use a different default prefix: ~/.local (we use the same on Linux) that should be writable by the user.

Ok, I've pushed a refinement to the instructions. However, they are still not clear. Is the default prefix /usr/local or /usr/local/bin? What exactly should be specified with the --prefix option? Should it be in quotes? Can you clarify this @lhstrh ? Thanks.

Currently, the default is ~/.local and /usr/local for Mac. I did it that way because, unlike on Linux, Mac allowed admin users to write to /usr/local. That has now changed. Is ~/.local on the PATH on Mac by default? If so, we can solve the problem differently, by just using ~/.local as the prefix across the board...

@edwardalee
Copy link
Contributor Author

On my Mac, ~/.local is not on my PATH by default, so this solution is no better than putting it somewhere random.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants