Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor video page #300

Merged
merged 5 commits into from
Dec 19, 2024
Merged

Refactor video page #300

merged 5 commits into from
Dec 19, 2024

Conversation

edwardalee
Copy link
Contributor

This changes the sidebar topic from "Tutorial Videos" to just "Videos" and makes some changes:

  • Add links to talks.
  • Add pointer to LF meeting recordings
  • Add pointer to short course
  • Deprecate the tutorial video, which is seriously out of date.

lhstrh
lhstrh requested changes Dec 18, 2024
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears docs/videos.mdx is missing.

lhstrh
lhstrh requested changes Dec 19, 2024
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there was a typo in the legacy routing. The rename was tutorial_videos.mdx -> videos.mdx, so the route should be from docs/tutorial-videos to docs/videos.

versioned_docs/version-0.9.0/legacy_routing.ts Outdated Show resolved Hide resolved
docs/legacy_routing.ts Outdated Show resolved Hide resolved
lhstrh
lhstrh approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@edwardalee edwardalee merged commit 9c268e5 into main Dec 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwardalee @lhstrh