Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update info on how to run Dockerfile #65

Merged
merged 5 commits into from
Nov 8, 2023

Conversation

erlingrj
Copy link
Collaborator

To build the Docker image you must be inside the src-gen/Foo directory

@lhstrh lhstrh requested a review from housengw June 20, 2022 20:48
Copy link

@housengw housengw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhstrh
Copy link
Member

lhstrh commented Sep 3, 2023

I guess this PR might be obsolete though, because in main it says:

docker build -t foo -f src-gen/Foo.Dockerfile .

(Notice the conflict and the text surrounding it.)

@erlingrj
Copy link
Collaborator Author

erlingrj commented Sep 4, 2023

You have to be inside src-gen/Foo when you invoke the Docker command.

@lhstrh lhstrh merged commit 1590f3b into lf-lang:main Nov 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants