Fix issue with app.overlay getting ignored #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that the
app.overlayfile would be ignored. The official (Nordic) DTS documentation states the order the .overlay files are searched for. Becauselfc's zephyr target always generates aboardsfolder with overlay files, the .overlay file in the boards folder will always be found and used. Thus, theapp.overlayfile is always ignored.The solution is to use the
DTC_OVERLAY_FILEvariable, as the documentation mentions.The problem is that this requires us to set both the .overlay files. Therefore, the
lfc.pyscript needs to know the board name as well. This changes the command the user needs to run from e.g.west lfc src/Control.lf --build "-p always -b nrf52dk_nrf52832"to
west lfc src/Control.lf --build "-p always" --board nrf52dk_nrf52832.So merging this PR requires us to update the official documentation as well.