Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RPi pico support for v0.7 #2283

Closed
wants to merge 3 commits into from
Closed

Add RPi pico support for v0.7 #2283

wants to merge 3 commits into from

Conversation

erlingrj
Copy link
Collaborator

@erlingrj erlingrj commented May 13, 2024

The RPi pico support needs updates to support v0.7. In this PR I make a few minor changes needed. I have not setup the pico toolchain locally so haven't tested it. See: #2282 Maybe @sberkun can follow up on it?

Would be great with a simple CI test that at least builds a hello world to avoid this in the future. Do you have any estimate of how hard that would be Samuel?

@erlingrj erlingrj marked this pull request as draft May 13, 2024 14:51
@erlingrj erlingrj changed the title Fix pico Add RPi pico support for v0.7 May 15, 2024
@erlingrj erlingrj added c Related to C target bugfix labels May 15, 2024
@sberkun
Copy link
Collaborator

sberkun commented May 25, 2024

Sorry for the delay! Following some recent changes (splitting the runtime into many CMake modules), the libraries need to be added to lf-low-level-platform-api as well as reactor-c. lf-lang/reactor-c#344 addresses lf-low-level-platform-api and this PR (or #2178) addresses reactor-c.

Setting up a compilation test should be doable, the main steps are:

  • install GCC cross compiler (see raspberrypi documentation)
  • clone the sdk
  • set PICO_SDK_PATH environment variable
  • compile (but not run) a hello-world test

I'm not familiar with how the automated tests are set up, but I imagine this could be accomplished by copying the Ubuntu tests and adding a few lines.

@edwardalee
Copy link
Collaborator

Looks like this change is also included in #2178, so I think this can be safely be closed.

@lhstrh
Copy link
Member

lhstrh commented May 29, 2024

Looks like this change is also included in #2178, so I think this can be safely be closed.

@sberkun, could you confirm this?

@lhstrh
Copy link
Member

lhstrh commented Jun 5, 2024

Given the lack of response I'm assuming it's safe to close this.

@lhstrh lhstrh closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix c Related to C target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants