Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

naming banked reactors #2320

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OmerMajNition
Copy link
Collaborator

#2319 has the description of the problem addressed with this PR

@OmerMajNition OmerMajNition requested a review from lhstrh June 14, 2024 15:00
@OmerMajNition OmerMajNition linked an issue Jun 14, 2024 that may be closed by this pull request
@OmerMajNition OmerMajNition self-assigned this Jun 14, 2024
@OmerMajNition OmerMajNition added the c Related to C target label Jun 14, 2024
@cmnrd
Copy link
Collaborator

cmnrd commented Jun 17, 2024

I am not entirely sure what this tries to achieve. Is this about getting the fully qualified names of reactors? I think we already provide functionality for that, also in the C target.

@cmnrd
Copy link
Collaborator

cmnrd commented Jun 20, 2024

@petervdonovan Could you comment on this? Are there FQNs available in C, and how are they exposed?

@petervdonovan
Copy link
Collaborator

Are there FQNs available in C, and how are they exposed?

If they are available in the C target, I am not aware of them, and after looking briefly I do not see them in the source code (in particular, there is no name field in the self_base_t struct defined here.

It looks like this PR adds FQNs without requiring any extension of self_base_t when the name field is not used, so I think we might as well merge it. CI is failing, but I think that should be easily fixed.

@cmnrd
Copy link
Collaborator

cmnrd commented Jun 21, 2024

Ok. I still don't understand what the PR does, though. @OmerMajNition could you add some explanation? Is the idea to introduce a magic parameter name that gets automatically assigned the FQN?

@OmerMajNition
Copy link
Collaborator Author

@cmnrd , I've added further description in GH-Issue: #2319. Please let me know if we need further clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c Related to C target
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

Reactor naming mechanism in C target
3 participants