Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add C target code generate to include socket_common.h #2449

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add C target code generate to include socket_common.h #2449

wants to merge 4 commits into from

Conversation

Jakio815
Copy link
Collaborator

@Jakio815 Jakio815 commented Dec 17, 2024 •
edited
Loading

Please merge together with lf-lang/reactor-c#505

@Jakio815 Jakio815 added the refactoring Code quality enhancement label Dec 17, 2024
@Jakio815 Jakio815 mentioned this pull request Dec 17, 2024
Open
@Jakio815 Jakio815 changed the title Draft: Add C target code generate to include socket_common.h Add C target code generate to include socket_common.h Dec 18, 2024
@Jakio815 Jakio815 marked this pull request as ready for review December 18, 2024 02:35
edwardalee
edwardalee approved these changes Dec 21, 2024
View reviewed changes
Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK, but the reactor-c PR should be merged first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardalee edwardalee edwardalee approved these changes

@hokeun hokeun hokeun approved these changes

Assignees
No one assigned
Labels
refactoring Code quality enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jakio815 @hokeun @edwardalee