-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clang-format and run it #310
Conversation
bab2973
to
28138f7
Compare
It is not urgent to make a decision, I think ideally we make a plan for when to apply it. Some point in the future when we have merged most of the big outstanding work. |
1865389
to
ea17944
Compare
There are several outstanding PRs, so this does not seem like a good time to do this. But it is something we should do. |
There is never a good time for something like this. If we want to do it (which I think we should), then we have to bite the bullet (like we did in the main LF repo). |
Hmm... doing this now will likely result in my ongoing cleanups getting abandoned... can we coordinate and it between major phases of this? I'm in the middle of one that has hundreds, maybe thousands of line changed. @erlingrj also has some large pending work. |
Sure, I just noticed this PR today and wanted to ping it and point out that there is never a perfect time. But if there is a concrete milestone to wait for, that is fine. |
How about instead providing the docs on how to set VS Code to do this formatting (in the developer section of the handbook), and also the instructions for how to do the mass formatting, and I will coordinate with @erling to find a good time to do this. |
We currently don't have developer instructions for the individual runtimes in the handbook. And I think we should keep those instructions in the README of the runtimes. Independent of where we place it, here is a simple description:
|
See #384 for clang-format run on main |
In this PR I copy over the formatter setup from reactor-cpp. I think we should use a formatter, we can argue about what the settings of it should be. Currently I put it at a column width of 80. Reactor-cpp uses 120.
The bigger question is when we should apply it. It will create problems for any outstanding feature-branch...