Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added lf_combine_deadline_and_level function for use by code generator #381

Merged
merged 2 commits into from
Mar 3, 2024

Conversation

edwardalee
Copy link
Contributor

This PR suppresses a warning (below) and consolidates the mechanism that is used to combine a deadline with a level into a single C function. As usual, there is a companion PR in lingua-franca. The warning was as follows:

/Users/edwardlee/git/epoch/org.lflang.ui/src/org/lflang/ui/wizard/templates/c/src-gen/Pipeline/Pipeline.c:562:91: warning: signed shift result (0x7FFFFFFFFFFFFFFF0000) requires 80 bits to represent, but 'long' only has 64 bits [-Wshift-overflow]
            pipeline_rp_self[pipeline_rp_i]->_lf__reaction_0.index = (9223372036854775807 << 16) | pipeline_rp_reaction_1_levels[pipeline_rp_i];
                                                                      ~~~~~~~~~~~~~~~~~~~ ^  ~~
1 warning generated.

@edwardalee edwardalee requested a review from lhstrh March 3, 2024 19:44
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

core/reactor_common.c Outdated Show resolved Hide resolved
@lhstrh lhstrh added this pull request to the merge queue Mar 3, 2024
Merged via the queue into main with commit 3a4e44f Mar 3, 2024
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants