Support for Patmos platform #383
Conversation
EhsanKhodadad
force-pushed
the
main
branch
3 times, most recently
from
f4d1af2 to
b3dcbac
Compare
|
Note that the Arduino tests are failing with this following error: |
|
You need an |
|
@EhsanKhodadad and @erlingrj could you guys please go over the conversations and resolve whatever issues have been resolved? Thanks! |
@EhsanKhodadad, could you respond to this? It seems we're super close to merging this, so let's try to get this across the finish line. |
WalkthroughThe recent changes enhance platform support for the Patmos architecture within the Lingua Franca framework. Key updates include new header files providing necessary APIs, modifications to CMake build configurations, and the introduction of critical support functions for managing interrupts and timing on the Patmos platform. These improvements aim to expand compatibility without impacting existing functionality or logic. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Outside diff range, codebase verification and nitpick comments (2)
low_level_platform/api/platform/lf_patmos_support.h (1)
51-52: Use standard format for closing include guard.Ensure consistency with the standard format.
- #endif // LF_PATMOS_SUPPORT_H + #endif /* LF_PATMOS_SUPPORT_H */low_level_platform/impl/src/lf_patmos_support.c (1)
112-114: Use standard format for closing preprocessor directive.Ensure consistency with the standard format.
- #endif // PLATFORM_PATMOS + #endif /* PLATFORM_PATMOS */
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- core/CMakeLists.txt (5 hunks)
- low_level_platform/api/low_level_platform.h (1 hunks)
- low_level_platform/api/platform/lf_patmos_support.h (1 hunks)
- low_level_platform/impl/CMakeLists.txt (3 hunks)
- low_level_platform/impl/src/lf_atomic_irq.c (1 hunks)
- low_level_platform/impl/src/lf_patmos_support.c (1 hunks)
Files skipped from review due to trivial changes (1)
- core/CMakeLists.txt
Additional comments not posted (8)
low_level_platform/api/platform/lf_patmos_support.h (2)
38-42: Verify the necessity of the NO_TTY macro.Ensure that the
NO_TTYmacro is required for the Patmos platform.
44-50: LGTM!The include statements and format specifiers are appropriate.
low_level_platform/impl/src/lf_atomic_irq.c (1)
1-1: LGTM! Verify the integration.The new preprocessor directive is correctly integrated.
Ensure that the integration does not affect existing functionality.
Verification successful
The PLATFORM_PATMOS directive is correctly integrated and follows the same pattern as other platform-specific directives.
low_level_platform/api/low_level_platform.hlow_level_platform/impl/src/lf_patmos_support.clow_level_platform/impl/src/lf_atomic_irq.cScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the integration of the new PLATFORM_PATMOS directive. # Test: Search for the PLATFORM_PATMOS directive. Expect: Correct integration without affecting existing functionality. rg --type c -A 5 $'PLATFORM_PATMOS'Length of output: 1709
Script:
#!/bin/bash # Description: Verify conditional compilation blocks and usage of PLATFORM_PATMOS directive. # Search for conditional compilation blocks in low_level_platform/api/low_level_platform.h rg --type c -A 5 '#elif defined(PLATFORM_PATMOS)' low_level_platform/api/low_level_platform.h # Search for conditional compilation blocks in low_level_platform/impl/src/lf_patmos_support.c rg --type c -A 5 '#if defined(PLATFORM_PATMOS)' low_level_platform/impl/src/lf_patmos_support.c # Search for conditional compilation blocks in low_level_platform/impl/src/lf_atomic_irq.c rg --type c -A 5 'defined(PLATFORM_PATMOS)' low_level_platform/impl/src/lf_atomic_irq.cLength of output: 283
Script:
#!/bin/bash # Description: Verify the usage and integration of the PLATFORM_PATMOS directive with broader context. # Search for PLATFORM_PATMOS directive and its surrounding context in low_level_platform/api/low_level_platform.h rg --type c -C 5 'PLATFORM_PATMOS' low_level_platform/api/low_level_platform.h # Search for PLATFORM_PATMOS directive and its surrounding context in low_level_platform/impl/src/lf_patmos_support.c rg --type c -C 5 'PLATFORM_PATMOS' low_level_platform/impl/src/lf_patmos_support.c # Search for PLATFORM_PATMOS directive and its surrounding context in low_level_platform/impl/src/lf_atomic_irq.c rg --type c -C 5 'PLATFORM_PATMOS' low_level_platform/impl/src/lf_atomic_irq.cLength of output: 1392
low_level_platform/impl/src/lf_patmos_support.c (3)
92-110: Ensure correct handling of nested critical sections.The logic for nested critical sections should be correctly implemented.
73-90: Ensure up-to-date clock functionality.The clock functionality should be correctly implemented and up-to-date.
31-38: Include missing headers.Ensure that all necessary headers are included.
+ #include "platform/lf_patmos_support.h" + #include "low_level_platform.h"Likely invalid or redundant comment.
low_level_platform/impl/CMakeLists.txt (1)
42-46: LGTM! Patmos platform support added correctly.The conditional block for the Patmos platform is well-structured and includes the necessary source files.
low_level_platform/api/low_level_platform.h (1)
51-52: LGTM! Patmos platform header included correctly.The
#elifblock for the Patmos platform is well-structured and includes the necessary header file.
Co-authored-by: Marten Lohstroh <[email protected]>
Co-authored-by: Marten Lohstroh <[email protected]>
Co-authored-by: erling <[email protected]>
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores