Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add address query reply message #392

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Add address query reply message #392

merged 3 commits into from
Mar 12, 2024

Conversation

Jakio815
Copy link
Collaborator

@Jakio815 Jakio815 commented Mar 11, 2024

This PR reopens #369

In decentralized coordination, the federate sends MSG_TYPE_ADDRESS_QUERY to the RTI with the payload being the ID of the federate it wishes to connect to.

Then, the RTI will reply with the remote federate's port number and IP address, using the same message header MSG_TYPE_ADDRESS_QUERY.

I suggest the reply message header to be changed from MSG_TYPE_ADDRESS_QUERY to MSG_TYPE_ADDRESS_QUERY_REPLY.

I just pushed the MSG_TYPE number down. Since 18 was empty, didn't need to push down all the numbers. Future work will to make it in enums.

Since this changes the protocol after this merge, the RTI must be rebuilt.

@Jakio815 Jakio815 changed the title Draft: Add address query reply message Draft: FIXPR: Add address query reply message Mar 11, 2024
@Jakio815 Jakio815 marked this pull request as ready for review March 11, 2024 19:03
@lhstrh lhstrh requested a review from edwardalee March 11, 2024 21:39
@Jakio815 Jakio815 changed the title Draft: FIXPR: Add address query reply message Add address query reply message Mar 11, 2024
@Jakio815 Jakio815 removed the python label Mar 11, 2024
@Jakio815 Jakio815 enabled auto-merge March 12, 2024 15:53
Copy link
Contributor

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This will create an incompatibility in the RTI, for which we have no versioning, but we will just have to deal with that.

@Jakio815 Jakio815 added this pull request to the merge queue Mar 12, 2024
Merged via the queue into main with commit 7427d98 Mar 12, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants