Add support for connecting multiports in TypeScript runtime. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…callee ports separately.
lhstrh
reviewed
Feb 17, 2022
…-multiport # Conflicts: # src/core/bank.ts # src/core/reactor.ts
…np, and remove unused code.
…-multiport # Conflicts: # src/core/bank.ts
Address cyclic dependencies + fix multiports
…e using classes from federation.ts.
…agnosing the bankIndex issue.
lhstrh
approved these changes
Mar 7, 2022
There was a problem hiding this comment.
There a lot that can still be improved upon, but this is already a good step in the right direction. Perhaps we should prioritize more cleanups and getting reactor-ts published on NPM so we can have a cleaner integration with LF (rather than copy code from a submodule).
| import {App, Triggers, Args} from '../src/core/reactor'; | ||
| import {Origin, TimeValue} from '../src/core/time'; | ||
| import {Reactor, Timer, Action, Sched} from '../src/core/reactor'; | ||
| import {App, Triggers, Args, Origin, TimeValue, Reactor, Timer, Sched, Action} from '../src/core/internal'; |
There was a problem hiding this comment.
Tests should probably not use the internal exports but the external ones, which we yet have to set up.
| @@ -0,0 +1,109 @@ | |||
|
|
|||
There was a problem hiding this comment.
Note sure whether we should have a dedicated file for types. Probably better to put these in files together with classes they relate to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant PR: lf-lang/lingua-franca#942
Relevant Issue: #57