-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flicker and auto run #105
Conversation
Your site is deployed at https://lfortran.github.io/pull_request_preview/lfortran/105 |
For every preview we have two build processes. One happens in this repository and pushes to the repository PS: It probably got completed in 4 minutes. This is similar to the issue we were facing here #94 (comment). |
Ah got it. It works! Here is what I am getting https://lfortran.github.io/pull_request_preview/lfortran/105?gist=certik/7e2652943bbff7f0d0963dd4fcf1813a But some other times it works great. It could be a caching problem, not sure. |
Also set default file name to main.f90
3b905a2
to
116c382
Compare
Your site is deployed at https://lfortran.github.io/pull_request_preview/lfortran/105 |
It #105 (comment) is fixed now.
I had noticed it once or twice while working on the PR, but I couldn't reproduce it. I also assumed it could be a caching issue. But since you also experienced it, I pondered over the code only to realize that it is a common issue experienced with callbacks. This happens specifically in the case of the param |
116c382
to
f258435
Compare
Your site is deployed at https://lfortran.github.io/pull_request_preview/lfortran/105 |
I think this fixes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this works!
Let's merge it, and we'll see how it goes. If I discover any further issues, I'll report them.
Thanks @Shaikh-Ubaid !
fixes #101
fixes #99
fixes #103
towards #104